Skip to content

Conversation

@Linu-Elias
Copy link
Contributor

@Linu-Elias Linu-Elias commented Aug 28, 2024

Proposed commit message

This update to the MSSQL integration documentation includes information indicating that, by default, the system-level database transaction_log metrics for SQL Server instances are collected. Metrics for user-level databases can be collected either by specifying a list of user databases or, alternatively, by enabling the Fetch from all databases toggle to collect metrics from all databases on the server.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@Linu-Elias Linu-Elias requested a review from a team as a code owner August 28, 2024 13:24
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Aug 28, 2024
@gpop63
Copy link
Contributor

gpop63 commented Aug 28, 2024

/test

@shmsr shmsr changed the title Update MSSQL Documentation packages/microsoft_sqlserver: Update documentation Aug 28, 2024
@Linu-Elias
Copy link
Contributor Author

/test

2 similar comments
@muthu-mps
Copy link
Contributor

/test

@Linu-Elias
Copy link
Contributor Author

/test

@shmsr
Copy link
Member

shmsr commented Aug 30, 2024

Hi @Linu-Elias. Can you see the buildkite logs or do you not have access? It is failing because of #10889 which I fixed in #10899

When the fix is merged to main, then you'd be able to merge this PR.

@Linu-Elias
Copy link
Contributor Author

Hi @Linu-Elias. Can you see the buildkite logs or do you not have access? It is failing because of #10889 which I fixed in #10899

When the fix is merged to main, then you'd be able to merge this PR.

yes @shmsr, I do have access and identified that the build is failing with error stating container status: unhealthy, I am waiting for the above PR to be merged. Thanks

@Linu-Elias
Copy link
Contributor Author

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Linu-Elias

@elastic-sonarqube
Copy link

@muthu-mps muthu-mps merged commit 89a7c82 into elastic:main Aug 30, 2024
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.9.2 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* Fix documentation issue on custom database metrics.

---------

Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: muthu-mps <[email protected]>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* Fix documentation issue on custom database metrics.

---------

Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: muthu-mps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants