-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump npcap version to 1.76 #315
Conversation
This pull request does not have a backport label. Could you fix it @efd6? 🙏
|
Test failure appears to be unrelated. |
These failures are not related to this PR but it cannot be merged until they are resolved. #311 contains a bit of context. |
It depends on the consumers. Golang-crossbuild follows the Golang versioning, only one minor version is supported. For instance, |
If you need this change in an existing Golang version, then it might be required to create a new branch following the naming And then backport the change using |
OK, thanks. This will only be for children of beats main (with no backports), which is at go1.20.8, so no backport other that go1.20 will be needed. |
@alexsapran and @pazone Would you mind taking a look please. |
I'm afraid I didn't explain this correctly. If this PR is merged and backported to If you need this change to be in NOTE: this is the reason we created https://github.com/elastic/golang-crossbuild/tree/1.17.5.x , so #148 could be available in I understand, this is a corner case ,that we have not needed in the past, but with |
OK. That's a lot of rigmarole. I'll see what I can do. |
Thanks for trying to understand my writing! To help with, let me ask you this:
If the former, then we need all that craziness. If the latter, then there is a need to request the Beats team to use |
I don't know what the time frame for a go1.20.9 is (Beats doesn't build with go1.21 yet). I guess it is likely to be before 8.11, so we could wait. It's not a wildly friendly system though. |
I can happily help with and make some notes so whoever needs to do this in the future can follow them. For doing so, let me know and merge this PR please :) |
I'm unable to merge this; it is still waiting for a review from @alexsapran. |
Sorry for that, I saw @pazone gave the 👍🏼 and I thought it was enough. |
Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit 1c5174b)
Co-authored-by: Dan Kortschak <[email protected]>
@Mergifyio backport 1.20.8.x |
✅ Backports have been created
|
Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit 1c5174b)
Co-authored-by: Dan Kortschak <[email protected]>
This bumps the version of the Npcap OEM installer to v1.76. The artifact has been placed in the private store.
Please take a look.
Query: What backports will be required for this change?
For elastic/beats#36539