Provide npcap distribution internally #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
v1v
commented
Jan 11, 2022
Makefile
Outdated
Comment on lines
3
to
6
| # TODO: to be replaced once we validate it works as expected | ||
| # TODO: version to be tagged too. | ||
| #NPCAP_FILE=npcap-1.60-oem.exe | ||
| NPCAP_FILE=test.txt |
There was a problem hiding this comment.
This will be replaced in a follow up, once we validate everything was pushed as expected
ifeq in Make with the include and variables created on the fly don't work as expected
v1v
commented
Jan 12, 2022
Makefile.common
Outdated
| push: | ||
| echo ">> Pushing $(REPOSITORY)/$(NAME):$(VERSION)$(SUFFIX)$(TAG_EXTENSION)" | ||
| @[ "$(SUFFIX)" = "$(SUFFIX_NPCAP_VERSION)" ] \ |
There was a problem hiding this comment.
I could not find the way to use ifeq with SUFFIX and SUFFIX_NPCAP_VERSION, even though these values were the same, but the ifeq returned false.
I guess, something should be related to where the SUFFIX is defined and the include function.
v1v
commented
Jan 12, 2022
Makefile
Outdated
Comment on lines
3
to
7
| # TODO: to be replaced once we validate it works as expected | ||
| # TODO: version to be tagged too. | ||
| NPCAP_VERSION=1.60 | ||
| #NPCAP_FILE=npcap-$(NPCAP_VERSION)-oem.exe | ||
| NPCAP_FILE=test.txt |
There was a problem hiding this comment.
TODO: to be replaced once we agree this is the way to go
Suggested change
| # TODO: to be replaced once we validate it works as expected | |
| # TODO: version to be tagged too. | |
| NPCAP_VERSION=1.60 | |
| #NPCAP_FILE=npcap-$(NPCAP_VERSION)-oem.exe | |
| NPCAP_FILE=test.txt | |
| NPCAP_VERSION=1.60 | |
| NPCAP_FILE=npcap-$(NPCAP_VERSION)-oem.exe |
mdelapenya
approved these changes
Jan 12, 2022
Otherwise the version was empty Let's see whether it works
…e specific makefile in the go1.X version folder
v1v
commented
Jan 12, 2022
Makefile.common
Outdated
Comment on lines
7
to
9
| # TODO: to be replaced once we validate it works as expected | ||
| #NPCAP_FILE := npcap-$(NPCAP_VERSION)-oem.exe | ||
| NPCAP_FILE := test.txt |
There was a problem hiding this comment.
Suggested change
| # TODO: to be replaced once we validate it works as expected | |
| #NPCAP_FILE := npcap-$(NPCAP_VERSION)-oem.exe | |
| NPCAP_FILE := test.txt | |
| NPCAP_FILE := npcap-$(NPCAP_VERSION)-oem.exe |
v1v
commented
Jan 12, 2022
|
|
||
| If you'd like to bump the npcap version please follow the below steps: | ||
|
|
||
| 1) Update `NPCAP_VERSION` value in the `Makefile`. |
There was a problem hiding this comment.
Suggested change
| 1) Update `NPCAP_VERSION` value in the `Makefile`. | |
| 1) Update `NPCAP_VERSION` value in the `Makefile.common`. |
then the push can be override
v1v
force-pushed
the
feature/support-pcap
branch
from
b77c6e9
to
4ff4855
Compare
kuisathaverat
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Provide the npcap distribution in an internal docker image, for such, it uses the internal docker registry, the main docker image and copy the file to
/installerfolder.Actions
npcapversion in the tag image.Test
Build
Push
Pull
Files