Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide npcap distribution internally #148

Merged
merged 17 commits into from
Jan 12, 2022
Merged

Provide npcap distribution internally #148

merged 17 commits into from
Jan 12, 2022

Commits on Jan 11, 2022

  1. Provide npcap distribution internally

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    507baf0 View commit details
    Browse the repository at this point in the history

  2. test: for testing purposes

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    762c067 View commit details
    Browse the repository at this point in the history

  3. Renamed

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7409208 View commit details
    Browse the repository at this point in the history

  4. Ensure it only publishes to a private docker registry when npcap

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5faa37f View commit details
    Browse the repository at this point in the history

  5. Use the GCP

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ae28a32 View commit details
    Browse the repository at this point in the history

  6. Run the make default goal

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9abcd05 View commit details
    Browse the repository at this point in the history

  7. Fix makefile condition

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    429b992 View commit details
    Browse the repository at this point in the history

  8. Add file to explain how to bump the version

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    98efac1 View commit details
    Browse the repository at this point in the history

  9. use NPCAP_VERSION

    @v1v
    v1v committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    146a157 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. use hardcoded string

    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    16a245d View commit details
    Browse the repository at this point in the history

  2. Add npcap image

    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    ad859c7 View commit details
    Browse the repository at this point in the history

  3. substitute the ifeq with a shell specific approach 

    ifeq in Make with the include and variables created on the fly don't work as expected
    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    8fe8e98 View commit details
    Browse the repository at this point in the history

  4. use npcap instead

    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    44cbaa4 View commit details
    Browse the repository at this point in the history

  5. Add explicit argument to the consumer 

    Otherwise the version was empty

Let's see whether it works
    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    cc80a4e View commit details
    Browse the repository at this point in the history

  6. Fix the variables when using either the top level root makefile or th… 

    …e specific makefile in the go1.X version folder
    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    c26271b View commit details
    Browse the repository at this point in the history

  7. refactor and use go1.1x/npcap/Makefile 

     then the push can be override
    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0d2e610 View commit details
    Browse the repository at this point in the history

  8. Enable ncpap

    @v1v
    v1v committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    4ff4855 View commit details
    Browse the repository at this point in the history