Skip to content

Feat/9577 add to dashboard icon#9590

Merged
l-suarez merged 3 commits into
elastic:mainfrom
l-suarez:feat/9577-add-to-dashboard-icon
Apr 13, 2026
Merged

Feat/9577 add to dashboard icon#9590
l-suarez merged 3 commits into
elastic:mainfrom
l-suarez:feat/9577-add-to-dashboard-icon

Conversation

@l-suarez
Copy link
Copy Markdown
Contributor

@l-suarez l-suarez commented Apr 13, 2026 •
edited
Loading

Summary

  • What: Added the addToDashboard icon, registered it in icon_map, documented it in the website icon types list, and updated Jest snapshots.
  • Why: Provides a dedicated glyph for “add to dashboard” actions so product UIs can avoid ambiguous reuse of generic plus / plusInCircle icons or dashboardApp alone, as described in the issue.
  • How: New artwork depicting a dashboard motif with a small “+” sub-glyph.

Fixes #9577

API Changes

component / parent prop / child change description
EuiIcon type Added addToDashboard

Screenshots

Before After
(no addToDashboard type) 11

Impact Assessment

  • Breaking changes
  • Visual changes — New optional EuiIcon type only; existing icons unchanged.
  • Test impact — EuiIcon snapshot updates for the new type.
  • Hard to integrate
    Impact level: Low

Release Readiness

  • Documentation: Listed in website icon types / icons docs once merged.
  • Figma: Tracked via #9577; further visual tuning in Figma if needed.
  • Migration guide: N/A
  • Adoption plan: Discover / Kibana (and similar flows) can switch to type="addToDashboard" where the action needs a distinct icon.

QA instructions for reviewer

  • Confirm addToDashboard appears in the Icons docs and Storybook icon listing.
  • Confirm the glyph is clear at 16×16 in light and dark mode (frame, chart, and + read as one concept).

Checklist before marking Ready for Review

  • Filled out sections above (per template).
  • QA: Light/dark, high contrast.
  • QA: CodeSandbox / Kibana (optional for icon-only change).
  • QA: Docs/types updated for the new icon name, added to Figma file
  • Tests: Jest snapshots updated (including after SVG simplification).
  • Changelog: `packages/eui/changelo

l-suarez added 2 commits April 13, 2026 12:05
@l-suarez
feat(icon): add addToDashboard icon
e56963e 
Adds the addToDashboard glyph (dashboard + sub-glyph +) for add-to-dashboard actions.

Refs: elastic#9577
Made-with: Cursor
@l-suarez
refactor(icon): simplify add_to_dashboard SVG
b558f33 
Replace mask and ids with a single evenodd frame path, drop mask fill,
and recompile the icon asset. Update Jest snapshots.

Made-with: Cursor
@l-suarez l-suarez self-assigned this Apr 13, 2026
@l-suarez l-suarez requested a review from a team as a code owner April 13, 2026 10:43
@l-suarez l-suarez added the icons label Apr 13, 2026
@l-suarez
fix(icon): update addToDashboard with final artwork
c1cfd39 
Use L-shaped frame via mask to clear the bottom-right corner for the
plus glyph, and merge the chart line and plus into a single path.

Made-with: Cursor
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Apr 13, 2026

💚 Build Succeeded

cc @l-suarez

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Apr 13, 2026

💚 Build Succeeded

cc @l-suarez

weronikaolejniczak
weronikaolejniczak approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @l-suarez! 🟢 Thank you for contributing 🙏🏻

@l-suarez l-suarez merged commit 2425c04 into elastic:main Apr 13, 2026
5 checks passed
@florent-leborgne florent-leborgne mentioned this pull request Apr 17, 2026
Merged
@tkajtoch tkajtoch mentioned this pull request Apr 20, 2026
Merged
@l-suarez l-suarez mentioned this pull request Apr 28, 2026
Open
@l-suarez l-suarez mentioned this pull request May 7, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weronikaolejniczak weronikaolejniczak weronikaolejniczak approved these changes

Assignees

@l-suarez l-suarez

Labels

icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New icon] Add to dashboard

3 participants

@l-suarez @elasticmachine @weronikaolejniczak