Skip to content

[Discover] Update "Add to dashboard" icons to use new addToDashboard #268159

Merged
l-suarez merged 2 commits into
elastic:mainfrom
l-suarez:fix/discover-add-to-dashboard-icon
May 13, 2026
Merged

[Discover] Update "Add to dashboard" icons to use new addToDashboard #268159
l-suarez merged 2 commits into
elastic:mainfrom
l-suarez:fix/discover-add-to-dashboard-icon

Conversation

@l-suarez
Copy link
Copy Markdown
Contributor

@l-suarez l-suarez commented May 7, 2026

Summary

Closes #266149

Updates all "Add to dashboard" actions in Discover to use the new addToDashboard EUI icon (added in elastic/eui#9590) instead of the generic dashboardApp icon, keeping the UI consistent with the latest icon set.

Changed locations:

  • Visualization — "Save visualization to dashboard" button in the histogram chart toolbar (kbn-unified-histogram)
  • Table — "Save table to dashboard" button in the documents layout (discover)
  • Metrics — "Copy to dashboard" action on Lens charts (kbn-unified-chart-section-viewer)

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Before After
image image

…icon

Replace dashboardApp icon with the newly added addToDashboard icon
across all "add/save/copy to dashboard" actions in Discover to align
with the latest EUI icon set.

Closes elastic#266149

Co-authored-by: Cursor <cursoragent@cursor.com>
@l-suarez l-suarez self-assigned this May 7, 2026
@l-suarez l-suarez requested review from a team as code owners May 7, 2026 11:36
@l-suarez l-suarez added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels May 7, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@l-suarez l-suarez added the backport:skip This PR does not require backporting label May 7, 2026
Copy link
Copy Markdown
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Laura! Yet another authored PR! 👏
Code looks good and I tested locally, all in order ✅

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 11, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - APM integration not installed but setup completed - Admin user
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.9MB 1.9MB +6.0B

History

cc @l-suarez

@l-suarez l-suarez merged commit 3dbf5c6 into elastic:main May 13, 2026
47 checks passed
DennisKo pushed a commit to DennisKo/kibana that referenced this pull request May 13, 2026
…lastic#268159)

## Summary

Closes elastic#266149

Updates all "Add to dashboard" actions in Discover to use the new
`addToDashboard` EUI icon (added in
elastic/eui#9590) instead of the generic
`dashboardApp` icon, keeping the UI consistent with the latest icon set.

**Changed locations:**
- **Visualization** — "Save visualization to dashboard" button in the
histogram chart toolbar (`kbn-unified-histogram`)
- **Table** — "Save table to dashboard" button in the documents layout
(`discover`)
- **Metrics** — "Copy to dashboard" action on Lens charts
(`kbn-unified-chart-section-viewer`)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


| Before | After |
|---|---|
|<img width="1219" height="1011" alt="image"
src="https://github.com/user-attachments/assets/7be71981-72ba-4bbd-b231-c0d96fee1fc0"
/>|<img width="2446" height="2028" alt="image"
src="https://github.com/user-attachments/assets/246d4645-d0f6-4257-8430-fe61df07405b"
/>|

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discover] Update “Add to dashboards” to use new icon

5 participants