[Infra] Upgrade dependencies that cause warnings when installing with React 18#7214
Merged
cee-chen merged 4 commits intoelastic:mainfrom Sep 26, 2023
Merged
[Infra] Upgrade dependencies that cause warnings when installing with React 18#7214cee-chen merged 4 commits intoelastic:mainfrom
cee-chen merged 4 commits intoelastic:mainfrom
Conversation
`vfile` dependency already has types at currently installed version
cee-chen
force-pushed
the
react-18-deps
branch
from
9b1dab6 to
19be91c
Compare
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
1Copenut
approved these changes
Sep 26, 2023
Contributor
1Copenut
left a comment
1Copenut
left a comment
There was a problem hiding this comment.
👍 LGTM! I ran through the manual QA with no issues.
Contributor
Author
|
Thanks a million Trevor! |
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Oct 4, 2023
`v88.5.0`⏩`v88.5.4` This EUI upgrade helps unblock the Shared UX team with some beta serverless nav updates not listed in the below changelog (elastic/eui#7228 and elastic/eui#7248). --- ## [`88.5.4`](https://github.com/elastic/eui/tree/v88.5.4) - This release contains internal changes to a beta component needed by Kibana. ## [`88.5.3`](https://github.com/elastic/eui/tree/v88.5.3) **Bug fixes** - Fixed `EuiComboBox` search input width not resetting correctly on selection ([#7240](elastic/eui#7240)) ## [`88.5.2`](https://github.com/elastic/eui/tree/v88.5.2) **Bug fixes** - Fixed broken `EuiTextTruncate` testenv mocks ([#7234](elastic/eui#7234)) ## [`88.5.1`](https://github.com/elastic/eui/tree/v88.5.1) - Improved the performance of `EuiComboBox` by removing the `react-autosizer-input` dependency ([#7215](elastic/eui#7215)) **Dependency updates** - Updated `react-element-to-jsx-string` to v5.0.0 ([#7214](elastic/eui#7214)) - Removed unused `@types/vfile-message` dependency ([#7214](elastic/eui#7214))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7080
QA
yarn build-pack, then move to the.tgzfile to somewhere you can easily point tonpx create-react-app test-eui-18-app && cd test-eui-18-apppackage.jsonand add@elastic/euipointed at the local tgz file, e.g."@elastic/eui": "/Users/YOURNAME/Documents/elastic-eui-88.4.1.tgz",src/App.jsand import and render anEuiButtonyarnwarning @elastic/euimessages while installing EUI (CRA has a few of its own, but shouldn't be related to EUI)yarn startEuiButtonrenders as expectedGeneral checklist