Merged
Conversation
cee-chen
added
release_note:skip
- should probably be cleaned up, but just using this for now to show principle
cee-chen
force-pushed
the
eui-v88.5.1
branch
from
6066aeb to
d79099d
Compare
`toHaveTextContent` no longer works on text that only lives in the input (vs in a combobox pill)
Contributor
|
Pinging @elastic/eui-team (EUI) |
jbudz
approved these changes
Sep 29, 2023
sebelga
approved these changes
Oct 2, 2023
Contributor
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
SharedUX changes LGTM! 🚀 Thanks a lot for bringing this PR ahead of schedule!
cnasikas
approved these changes
Oct 2, 2023
vitaliidm
approved these changes
Oct 3, 2023
Contributor
vitaliidm
left a comment
vitaliidm
left a comment
There was a problem hiding this comment.
Detection Engine area LGTM
Contributor
Author
|
Thanks everyone for the super speedy reviews! 💚 As a heads up, the EUI team will be waiting for the 8.11 branch to be cut before merging, as this upgrade is not critical/necessary to get into 8.11, and we want to reduce FF QA churn. |
- to grab latest requested serverless nav changes
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v88.5.0⏩v88.5.4This EUI upgrade helps unblock the Shared UX team with some beta serverless nav updates not listed in the below changelog (elastic/eui#7228 and elastic/eui#7248).
88.5.488.5.3Bug fixes
EuiComboBoxsearch input width not resetting correctly on selection (#7240)88.5.2Bug fixes
EuiTextTruncatetestenv mocks (#7234)88.5.1EuiComboBoxby removing thereact-autosizer-inputdependency (#7215)Dependency updates
react-element-to-jsx-stringto v5.0.0 (#7214)@types/vfile-messagedependency (#7214)