-
Notifications
You must be signed in to change notification settings - Fork 863
[EuiSuggest] Accept isPreFiltered prop
#5930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSuggest] Accept isPreFiltered prop
#5930
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Hey @omar-zahid, When you're ready for review, please update the summary and check or remove each checklist item. Also, sign the CLA if you haven't already done so. Thanks! |
|
Thanks @thompsongl Sure. I have also signed the CLA however its not being reflected as signed here, not sure why. |
|
Thanks! Could you also add a changelog entry? jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5930/ |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
Hey @omar-zahid Just let us know! Thanks again for helping out! |
|
Hi @thompsongl Sorry been away for a while. It would be helpful if you can take it from here. I would love to have this feature merged in. |
|
Not a problem! We will get the branch updated and this PR merged. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5930/ |
Summary
EuiSuggestpropscurrently does not acceptisPreFilteredprop which does exist in theSelectablecomponent.From the documents,
isPreFiltered:Recommending to allow
EuiSuggestcomponent to acceptisPreFilteredprop to introduce the same functionality above toEuiSuggestcomponentChecklist