Skip to content

[EuiSuggest] Accept isPreFiltered prop #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2022
Merged

[EuiSuggest] Accept isPreFiltered prop #5930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33dc06a
Accept isPreFiltered prop. Passing it directly to EuiSelectable
omar-zahid May 25, 2022
bd72db4
Documentation fix: Grammar
omar-zahid May 25, 2022
f9fd8bc
Merge branch 'main' into suggest-allow-isprefiltered
thompsongl Sep 6, 2022
91e9c68
CL
thompsongl Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/suggest/suggest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ type _EuiSuggestProps = CommonProps &
* Default is `60vh`
*/
maxHeight?: CSSProperties['maxHeight'];

/**
* Control whether or not options get filtered internally or if consumer will filter.
* Default `false`
*/
isPreFiltered?: boolean;
};

export type EuiSuggestProps = _EuiSuggestProps &
Expand Down Expand Up @@ -138,6 +144,7 @@ export const EuiSuggest: FunctionComponent<EuiSuggestProps> = ({
id,
'aria-label': ariaLabel,
'aria-labelledby': labelId,
isPreFiltered = false,
isVirtualized = false,
fullWidth = true,
maxHeight = '60vh',
Expand Down Expand Up @@ -297,6 +304,7 @@ export const EuiSuggest: FunctionComponent<EuiSuggestProps> = ({
isVirtualized,
}}
searchable
isPreFiltered={isPreFiltered}
searchProps={{
id,
append: appendArray.length ? appendArray : undefined,
Expand Down
2 changes: 2 additions & 0 deletions upcoming_changelogs/5930.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Updated `EuiSuggest` to accept the `isPreFiltered` prop