Bumping EUI to version 67.1.8 #141279
Merged
Bumping EUI to version 67.1.8 #141279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UI to EuiButtonColor.
breehall
added
release_note:skip
… where the EUI versions were out of sync
…o return an empty string instead of undefined when the label is unavailable
…is was renamed in PR #6150
…EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles
…escriptionList, EuiButtonIcon, and EuiBadge Emotion conversions.
…List, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles
…ion conversion.
…ion conversion.
…and EuiButton Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
…EuiButton Emotion conversions.
…iBadge, EuiButtonIcon, and EuiCard Emotion conversions. Updated snapshots for EuiToolTtip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles
…lor'] as it was removed in PR #6150
…t a generic button to prevent undefined click event errors
…EuiCard Emotion conversions
…ut has been converted to Emotion and the Sass styles are no longer available in EUI
…allOut has been converted to Emotion and the Sass styles are no longer available in EUI
… conversions. Updated snapshots in server_status.test.tsx to render EuiBadge before checking the snapshots to reduce the snapshot churn caused by Emotion. Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
…-ref HEAD~1..HEAD --fix'
…rade-67.1.2 Pulling in code from main branch
…into eui-upgrade-67.1.2 Pull code from working branch
…llOut mixin as the component has been converted to Emotion and is no longer available for use.
Updated snaphshots to account for EuiBadge, EuiDescriptionList, EuiFlyout, and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles. Updated tests that target EuiButton to simulate click events to target a generic button element to prevent undefined click event errors
…mulate click events to target a generic button to prevent undefined click event errors
…et EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors
stratoula
requested changes
Nov 7, 2022
Contributor
There was a problem hiding this comment.
Vega specs which add scrolls don't work correctly.
Check this spec:
Open
{
"$schema": "https://vega.github.io/schema/vega/v5.json",
"background": "white",
"autosize": {"type": "pad", "resize": true, "contains": "padding"},
"padding": 5,
"data": [
{
"name": "source_0",
"url": {
"%context%": true,
"index": "kibana_sample_data_ecommerce",
"body": {
"size": 384,
"_source": ["customer_first_name", "total_unique_products"]
}
},
"format": {"property": "hits.hits", "type": "json", "parse": {}},
"transform": [
{
"type": "formula",
"expr": "datum[\"_source\"] && datum[\"_source\"][\"customer_first_name\"]",
"as": "_source.customer_first_name"
},
{
"type": "formula",
"expr": "datum[\"_source\"] && datum[\"_source\"][\"total_unique_products\"]",
"as": "_source.total_unique_products"
},
{
"type": "stack",
"groupby": ["_source", "_source\\.customer_first_name"],
"field": "_source\\.total_unique_products",
"sort": {
"field": ["_source\\.customer_first_name"],
"order": ["descending"]
},
"as": [
"_source.total_unique_products_start",
"_source.total_unique_products_end"
],
"offset": "zero"
},
{
"type": "filter",
"expr": "isValid(datum[\"_source.total_unique_products\"]) && isFinite(+datum[\"_source.total_unique_products\"])"
}
]
},
{
"name": "column_domain",
"source": "source_0",
"transform": [
{"type": "aggregate", "groupby": ["_source\\.customer_first_name"]}
]
}
],
"signals": [
{"name": "x_step", "value": 20},
{
"name": "child_width",
"update": "bandspace(domain('x').length, 0.1, 0.05) * x_step"
},
{"name": "child_height", "value": 200}
],
"layout": {
"padding": 20,
"titleAnchor": {"column": "end"},
"offset": {"columnTitle": 10},
"columns": {"signal": "length(data('column_domain'))"},
"bounds": "full",
"align": "all"
},
"marks": [
{
"name": "column-title",
"type": "group",
"role": "column-title",
"title": {
"text": "_source.customer_first_name",
"style": "guide-title",
"orient": "bottom",
"offset": 10
}
},
{
"name": "row_header",
"type": "group",
"role": "row-header",
"encode": {"update": {"height": {"signal": "child_height"}}},
"axes": [
{
"scale": "y",
"orient": "left",
"grid": false,
"title": "STL Average Throughput elements/sec,",
"tickCount": 5,
"labelOverlap": true,
"zindex": 0
}
]
},
{
"name": "column_footer",
"type": "group",
"role": "column-footer",
"from": {"data": "column_domain"},
"sort": {
"field": "datum[\"_source.customer_first_name\"]",
"order": "ascending"
},
"title": {
"text": {
"signal": "isValid(parent[\"_source.customer_first_name\"]) ? parent[\"_source.customer_first_name\"] : \"\"+parent[\"_source.customer_first_name\"]"
},
"style": "guide-label",
"frame": "group",
"orient": "bottom",
"offset": 10
},
"encode": {"update": {"width": {"signal": "child_width"}}}
},
{
"name": "cell",
"type": "group",
"style": "cell",
"from": {
"facet": {
"name": "facet",
"data": "source_0",
"groupby": ["_source\\.customer_first_name"]
}
},
"sort": {
"field": ["datum[\"_source.customer_first_name\"]"],
"order": ["ascending"]
},
"encode": {
"update": {
"width": {"signal": "child_width"},
"height": {"signal": "child_height"}
}
},
"marks": [
{
"type": "group",
"from": {
"facet": {
"data": "facet",
"name": "stack_group_child_main",
"groupby": ["_source"],
"aggregate": {
"fields": [
"_source\\.total_unique_products_start",
"_source\\.total_unique_products_start",
"_source\\.total_unique_products_end",
"_source\\.total_unique_products_end"
],
"ops": ["min", "max", "min", "max"]
}
}
},
"encode": {
"update": {
"x": {"scale": "x", "field": "_source"},
"width": {"scale": "x", "band": 1},
"y": {
"signal": "min(scale('y',datum[\"min__source.total_unique_products_start\"]),scale('y',datum[\"max__source.total_unique_products_start\"]),scale('y',datum[\"min__source.total_unique_products_end\"]),scale('y',datum[\"max__source.total_unique_products_end\"]))"
},
"y2": {
"signal": "max(scale('y',datum[\"min__source.total_unique_products_start\"]),scale('y',datum[\"max__source.total_unique_products_start\"]),scale('y',datum[\"min__source.total_unique_products_end\"]),scale('y',datum[\"max__source.total_unique_products_end\"]))"
},
"clip": {"value": true},
"cornerRadius": {"value": 5}
}
},
"marks": [
{
"type": "group",
"encode": {
"update": {
"y": {"field": {"group": "y"}, "mult": -1},
"width": {"field": {"group": "width"}}
}
},
"marks": [
{
"name": "child_marks",
"type": "rect",
"style": ["bar"],
"from": {"data": "stack_group_child_main"},
"encode": {
"update": {
"tooltip": {
"signal": "{\"_source.\": isValid(datum[\"_source\"]) ? datum[\"_source\"] : \"\"+datum[\"_source\"], \"_source.total_unique_products\": format(datum[\"_source.total_unique_products\"], \"\"), \"_source.customer_first_name\": isValid(datum[\"_source.customer_first_name\"]) ? datum[\"_source.customer_first_name\"] : \"\"+datum[\"_source.customer_first_name\"]}"
},
"fill": {
"scale": "color",
"field": "_source\\.customer_first_name"
},
"ariaRoleDescription": {"value": "bar"},
"description": {
"signal": "\"_source.: \" + (isValid(datum[\"_source\"]) ? datum[\"_source\"] : \"\"+datum[\"_source\"]) + \"; _source.total_unique_products: \" + (format(datum[\"_source.total_unique_products\"], \"\")) + \"; _source.customer_first_name: \" + (isValid(datum[\"_source.customer_first_name\"]) ? datum[\"_source.customer_first_name\"] : \"\"+datum[\"_source.customer_first_name\"])"
},
"width": {"field": {"group": "width"}},
"y": {
"scale": "y",
"field": "_source\\.total_unique_products_end"
},
"y2": {
"scale": "y",
"field": "_source\\.total_unique_products_start"
}
}
}
}
]
}
]
}
],
"axes": [
{
"scale": "y",
"orient": "left",
"tickCount": 5,
"gridScale": "x",
"grid": true,
"domain": false,
"labels": false,
"aria": false,
"maxExtent": 0,
"minExtent": 0,
"ticks": false,
"zindex": 0
}
]
}
],
"scales": [
{
"name": "x",
"type": "band",
"domain": {"data": "source_0", "field": "_source", "sort": true},
"range": {"step": {"signal": "x_step"}},
"paddingInner": 0.1,
"paddingOuter": 0.05
},
{
"name": "y",
"type": "linear",
"domain": {
"data": "source_0",
"fields": [
"_source\\.total_unique_products_start",
"_source\\.total_unique_products_end"
]
},
"range": [{"signal": "child_height"}, 0],
"nice": true,
"zero": true
},
{
"name": "color",
"type": "ordinal",
"domain": {
"data": "source_0",
"field": "_source\\.customer_first_name",
"sort": true
},
"range": {"scheme": "tableau20"}
}
],
"legends": [
{
"fill": "color",
"symbolType": "square",
"title": "_source.customer_first_name"
}
],
"config": {"style": {"cell": {"stroke": "transparent"}}}
}
This is how it should be(main)
This is how it looks on this PR (no scrollbars, autosize on resizing the panel doesn't work)
vitaliidm
approved these changes
Nov 7, 2022
Contributor
vitaliidm
left a comment
vitaliidm
left a comment
There was a problem hiding this comment.
rules alerts area LGTM
maxcold
approved these changes
Nov 7, 2022
Contributor
Author
@stratoula this sounds similar to Andrew's finding. Would this be the same change you're referring to? Also, do you mind telling me how I can find the view you're referencing? |
Contributor
|
@breehall Go to Visualize, Create a new visualization and click Custom Visualization
There copy paste the spec I sent you. |
…ScrollStyles not to present the scroll bars in Vega Vis
…rade-67.1.2 Pulling main
Contributor
Author
@stratoula I just pushed a change for this. Do you mind verifying that you see the scroll bars on your end? This is what I'm able to see now:
|
…ave been included in the actual class name
Contributor
Author
|
@elasticmachine merge upstream |
davismcphee
approved these changes
Nov 7, 2022
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
I was asked to give another quick review on the Vega specs issue. Can confirm everything LGTM on my end 👍
chandlerprall
approved these changes
Nov 7, 2022
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[email protected] ⏩ [email protected]
67.1.8Bug fixes
EuiCardnot correctly mergingcsson its childicons (#6341)EuiCheckableCardnot settingcsson the correct DOM node (#6341)EuiModals containingEuiBasicTables tall enough to scroll (#6343)67.1.7Bug fixes
EuiBetaBadgeto always respect itsanchorPropsvalues, including when there is no tooltip content (#6326)enabledoption to the<EuiInMemoryTable />executeQueryOptionsprop. This option prevents the Query from being executed when controlled by the consumer. (#6284)hintprop to the<EuiSearchBar />. This prop lets the consumer render a hint below the search bar that will be displayed on focus. (#6319)hasDragDropprop toEuiPopover. Use this prop if your popover containsEuiDragDropContext. (#6329)EuiModalto not cause scroll-jumping issues on modal open (#6327)EuiPageTemplatenot recognizing childEuiPageSidebars/EuiPageTemplate.Sidebars withcssprops (#6324)EuiTourwhere passing anypanelPropswould cause the beacon to disappear (#6298)EuiBreadcrumbs'sbreadcrumbsarray not respectingtruncateoverrides (#6280)67.1.6Bug fixes
EuiButtonnot correctly passingtextPropsfor children inside fragments or i18n components (#6332)EuiButtonnot correctly respectingminWidth={0}(#6332)67.1.5Bug fixes
EuiButton's cursor style when the button is disabled (#6323)67.1.4Bug fixes
EuiHeaderCSS using removedEuiOverlayMaskclass modifiers (#6293)67.1.3Bug fixes
EuiOverlayMaskto set a[data-relative-to-header=above|below]attribute to replace the--aboveHeaderand--belowHeaderclassNames removed in its Emotion conversion67.1.2Bug fixes
EuiFlyoutnot correctly merging passedcss(#6248)EuiNotificationEventnot correctly merging passedclassNames (#6248)EuiAvatarto no longer mutate the object passed to itsstyleprop (#6251)67.1.1Bug fixes
EuiDataGrid's broken fullscreen mode when nested within anEuiAccordion(#6235)EuiPageSectionnot correctly mergingcontentProps.css(#6239)EuiPageHeaderContentnot correctly merging passedclassNames (#6239)EuiAccordionnot correctly mergingbuttonProps.cssandarrowProps.css(#6239)EuiProgressnot correctly merginglabelProps.css(#6239)EuiImagenot correctly mergingwrapperProps.css(#6239)CSS-in-JS conversions
EuiFlyoutto Emotion; Removed$euiFlyoutBorderand$euiFlyoutPaddingModifiers(#6213)67.1.0EuiProvider(#6216)EuiBadge's disabled styling to matchEuiButton(#6224)custom_componentsearch filter type for the EuiSearchBar. This new type gives the consumer control to render the search filter dropdown. (#6226)Bug fixes
Query.toESQuery()to generate bool queries instead of relying on match query logic, to work with non-text fields (#6220)EuiInMemoryTable's internal state tracking to include changes ofsorting.sortvalues (#6228)EuiButtonwhereiconSizewas not being applied (#6230)CSS-in-JS conversions
EuiBadgeto Emotion (#6224)67.0.0EuiSuggestto accept theisPreFilteredprop (#5930)EuiOverlayMaskto useEuiPortal(#6090)EuiToolTipPopoverto be a function component (#6104)EuiToolTipAnchorandEuiToolTipArrowcomponents (#6104)componentprop toEuiPageSection, allowing overriding of the defaultsectiontag (#6192)Bug fixes
EuiProvidercache is not configured. (#6202)classNameandrestprops were not being passed to theEuiNotificationEvent(#6208)componentPropsthrowing type errors on thecssprop (#6211)Deprecations
@deprecatedflags toEuiPageContent_Deprecated,EuiPageContentBody_Deprecated,EuiPageContentHeader_Deprecated,EuiPageContentHeaderSection_Deprecated,EuiPageSideBar_DeprecatedandEuiPageTemplate_Deprecated, which will provide helpful hints to IDEs that support jsdoc flags. Consumers will have until August 2023 to migrate from these deprecated components. (#6194)Breaking changes
onClickprop fromEuiOverlayMask. Use a nestedEuiFocusTrapinstead. (#6090)euiCallOutColorSass mixin (#6201)CSS-in-JS conversions
EuiOverlayMaskto Emotion (#6090)EuiToolTipto Emotion styling (#6104)EuiPagination,EuiPaginationButton, andEuiPaginationButtonArrowto Emotion (#6109)66.0.0gutterSizeprop toEuiDescriptionList(#6175)tooltipTextas an optional prop onEuiListGroupItem(#6186)Bug fixes
EuiHeaderSectionItemto not render if empty (#6158)useEuiTheme's return value, supporting React's shallow prop comparison optimizations (#6165)EuiPageSidebarbug where inline styles were not correctly updating (#6191)Breaking changes
.euiIEFlexWrapFixglobal className andinternetExplorerOnly()Sass mixin, as IE is no longer a supported browser (#6154)65.0.2Bug fixes
EuiDataGridcell popover shadows in Safari (#6163)EuiIconfrom loading icons asynchronously (#6166)65.0.1Note: this version contains a bug preventing its usage, fixed in
65.0.2Bug fixes
EuiDescriptionListTitlewhenEuiDescriptionListis compressed (#6160)65.0.0Note: this version contains a bug preventing its usage, fixed in
65.0.2anchorPropsto allow passing more props to the anchoring wrapper inEuiToolTipandEuiBetaBadge(#6110)hollowstyleEuiBetaBadge(#6110)selectableEuiCards (#6110)ghostcolors to becolorMode = 'dark'themedtextbuttons (#6150)ButtonColorandButtonSizetypes to prefixed versionsEuiButtonColorandEuiButtonSize(#6150)Deprecations
ghostcolor forEuiButton,EuiButtonIcon,EuiButtonEmpty(#6150)Breaking changes
EuiButtonIconColorandEuiButtonEmptyColortypes, useEuiButtonIconProps['color']andEuiButtonEmptyProps['color']instead (#6150)ghostcolor fromEuiButtonGroup(#6150)CSS-in-JS conversions
euiHasBetaBadge()Sass mixin (#6110)EuiCard,EuiCheckableCardto Emotion, removed$euiCheckableCardPadding,$euiCardSpacing,$euiCardBottomNodeHeight,$euiCardSelectButtonBorders,$euiCardSelectButtonBackgrounds, and$euiCardPaddingModifiers(#6110)EuiButtonto Emotion (#6150)EuiButtonIcon,EuiButtonEmpty,EuiButtonGroup(#6150)64.0.5Note: this release is a backport containing changes originally made in
67.1.0,67.1.1, and67.1.2Bug fixes
EuiInMemoryTable's internal state tracking to include changes ofsorting.sortvalues (#6228)EuiDataGrid's broken fullscreen mode when nested within anEuiAccordion(#6235)EuiAvatarto no longer mutate the object passed to itsstyleprop (#6251)