Fixed disabled text styles in Safari (and iOS)#4538
Merged
cchaos merged 2 commits intoelastic:masterfrom Feb 18, 2021
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4538/ |
cchaos
changed the title
anuragxxd
added a commit
to anuragxxd/eui
that referenced
this pull request
Feb 18, 2021
Fixed disabled text styles in Safari (and iOS) (elastic#4538)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gjones Brought to our attention that the text of filled, disabled inputs on Safari did not have proper contrast. Apparently, in Safari, there is a special☹️
-webkit-prefix for applyingcolorto disabled text of inputs.So based on this SO, I've forced
opacity(for iOS) in the reset files, then applied the disabled textcolorin the Sass mixin to the-webkit-prefix.Before
After
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes