Skip to content

[EuiFieldNumber] Add string as valid value type #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thompsongl merged 7 commits into from
Mar 10, 2020
Merged

[EuiFieldNumber] Add string as valid value type #3020

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fcf2703
[EuiFieldNumber] Add `string` as valid value type
sorenlouv Mar 9, 2020
dae3cbd
Update src/components/form/field_number/field_number.tsx
sorenlouv Mar 10, 2020
bcd9a7f
Don't override `value` with custom type (use default from `InputHTMLA…
sorenlouv Mar 10, 2020
686f3f1
Update CHANGELOG.md
sorenlouv Mar 10, 2020
a05c67f
Merge branch 'master' into add-string-as-value-type
sorenlouv Mar 10, 2020
00ae420
Update CHANGELOG.md
sorenlouv Mar 10, 2020
183d2c9
Update CHANGELOG.md
sorenlouv Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/form/field_number/field_number.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { IconType } from '../../icon';

export type EuiFieldNumberProps = InputHTMLAttributes<HTMLInputElement> &
CommonProps & {
value?: number | '';
value?: string | number;
Comment thread
sorenlouv marked this conversation as resolved.
Outdated
Comment thread
sorenlouv marked this conversation as resolved.
Outdated
icon?: IconType;
isInvalid?: boolean;
fullWidth?: boolean;
Expand Down