Skip to content

Comments

Added @types/sinon as dependency#2924

Closed
anishagg17 wants to merge 3 commits intoelastic:masterfrom
anishagg17:dep
Closed

Added @types/sinon as dependency#2924
anishagg17 wants to merge 3 commits intoelastic:masterfrom
anishagg17:dep

Conversation

@anishagg17
Copy link
Contributor

Summary

Added @types/sinon as dependency

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl
Copy link
Contributor

We just removed all usage of sinon in #2885

@thompsongl thompsongl closed this Feb 25, 2020
@anishagg17 anishagg17 deleted the dep branch February 25, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants