Use requestAnimationFrame on EuiComboBox singleSelection close#2326
Merged
thompsongl merged 4 commits intoelastic:masterfrom Sep 11, 2019
Merged
Use requestAnimationFrame on EuiComboBox singleSelection close#2326thompsongl merged 4 commits intoelastic:masterfrom
thompsongl merged 4 commits intoelastic:masterfrom
Conversation
thompsongl
changed the title
snide
approved these changes
Sep 11, 2019
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
I tested this locally over VM. Seems to do the trick.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2303, which is an IE11 bug caused by a focus event and
setStatemistiming. IE11 needs a tick between callingfocus()andsetStateso that the latter always happens second and prevents re-opening of the list.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes