Skip to content

Use requestAnimationFrame on EuiComboBox singleSelection close #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thompsongl merged 4 commits into from
Sep 11, 2019
Merged

Use requestAnimationFrame on EuiComboBox singleSelection close #2326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d91415
settimeout on singleselection close
thompsongl Sep 10, 2019
9ea7d53
use requestAnimationFrame instead
thompsongl Sep 11, 2019
b23b96f
CL
thompsongl Sep 11, 2019
f1cf9c7
Merge branch 'master' into 2303-combobox-close
thompsongl Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Corrected `EuiCodeBlock`'s proptype for `children` to be string or array of strings. ([#2324](https://github.com/elastic/eui/pull/2324))
- Fixed `onClick` TypeScript definition for `EuiPanel` ([#2330](https://github.com/elastic/eui/pull/2330))
- Fixed `EuiComboBox` list reopening after closing on option selection in IE11 ([#2326](https://github.com/elastic/eui/pull/2326))

## [`13.8.1`](https://github.com/elastic/eui/tree/v13.8.1)

Expand Down
2 changes: 1 addition & 1 deletion src/components/combo_box/combo_box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ export class EuiComboBox extends Component {
}

if (singleSelection) {
this.closeList();
requestAnimationFrame(this.closeList);
}
};

Expand Down