Merged
Conversation
Contributor
Author
Contributor
💔 Build Failed |
Contributor
Author
|
Code owner pings are for updated snaps only. |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
@cchaos and I talked about this. We're gonna see if we can blaze through some of the easy fixes with the form row visual breaks as part of this PR. |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
This comment has been minimized.
This comment has been minimized.
sorenlouv
approved these changes
Sep 12, 2019
This comment has been minimized.
This comment has been minimized.
Contributor
|
@cchaos just a note for your morning. I think I did a pretty decent scan of:
I did code scans of
I think we're looking pretty good. |
This reverts commit 4fd7c62b97cdbf1895052610f7d057eb930c9144.
bc8c983 to
9544955
Compare
Contributor
💚 Build Succeeded |
snide
approved these changes
Sep 16, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
Looks good. Let's merge this and start the work of making cool compressed forms. For solution teams, if you notice any fallout breaks in your forms that you can't solve yourself I've made the following meta ticket to track. #45812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

14.0.0Feature: Compressed Form Controls (#2167)
compressedform controls to look more subtleEuiFormControlLayoutDelimitedfor dual inputs indicating a rangeEuiFormRowviadisplaypropcompressedEuiRangeandEuiDualRangeshowInput = 'inputWithPopover'option forcompressedEuiRangeandEuiDualRangeto display the slider in a popoverEuiSuperDatePickerpopovercompressedcontrolOnlyprop toEuiFieldTextandEuiFieldNumberstyleprop to be passed down inEuiColorPickerSwatchEuiFilePickernow hasdefaultandlargedisplay sizes that both havecompressedalternativesappend/prependprops and added a11y supportEuiSuperSelectBug fixes
EuiColorPickerpadding on right to accomodate down caretEuiComboBoxand pillsEuiContextMenuItemappend/prependoptions ofEuiFormControlLayoutDeprecations
EuiFormRow'scompressedprop deprecated in favor ofdisplay: rowCompressedEuiFormRow'sdisplayOnlyprop deprecated in favor ofdisplay: centerBreaking changes
euiTextOverflowWrap()has been removed in favor ofeuiTextBreakWord()EuiFormLabelno longer has a bottom marginEuiFormRowno longer has bottom padding, nor does it add margin to any+ *siblings only siblingEuiFormRows13.8.2Bug fixes
EuiCodeBlock's proptype forchildrento be string or array of strings. (#2324)onClickTypeScript definition forEuiPanel(#2330)EuiComboBoxlist reopening after closing on option selection in IE11 (#2326)The checklist
compressedprop.compressedissuesFollow up todos
compressedprops on EuiCombBox because of missing TS type. Will be fixed in Compressed Fixes Round 1 eui#2338