Skip to content

Fix cascade issue with adding className to EuiPageContent #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zacqary merged 2 commits into from
Aug 19, 2019
Merged

Fix cascade issue with adding className to EuiPageContent #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9681fd9
Fix cascade issue with adding className to EuiPageContent
Zacqary Aug 16, 2019
62733ce
Add changelog entry
Zacqary Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Removed Firefox's focus ring to match other browsers ([#2193](https://github.com/elastic/eui/pull/2193))
- Added missing `onChange` TS defs for EuiRange ([#2211](https://github.com/elastic/eui/pull/2211))
- Fixed `EuiBadge` text cursor to default pointer ([#2234](https://github.com/elastic/eui/pull/2234))
- Fixed `EuiPageContent` className prop to allow the passed-in className to take cascade precedence over classes generated by the component ([#2237](https://github.com/elastic/eui/pull/2237))

## [`13.3.0`](https://github.com/elastic/eui/tree/v13.3.0)

Expand Down
4 changes: 2 additions & 2 deletions src/components/page/page_content/page_content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ export const EuiPageContent = ({
}) => {
const classes = classNames(
'euiPageContent',
className,
verticalPositionToClassNameMap[verticalPosition],
horizontalPositionToClassNameMap[horizontalPosition]
horizontalPositionToClassNameMap[horizontalPosition],
className
);

return (
Expand Down