[ML] Fixes anomalies table sort behavior when sorting on severity#40600
Merged
peteharverson merged 1 commit intoelastic:masterfrom Jul 9, 2019
Merged
Conversation
peteharverson
added
review
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jul 9, 2019
peteharverson
added a commit
that referenced
this pull request
Jul 9, 2019
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jul 10, 2019
peteharverson
added a commit
that referenced
this pull request
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the sort behavior of the anomalies table when sorting on the
severitycolumn and switching the aggregation interval to 'Show all'.Recent changes made to
EuiInMemoryTablein elastic/eui#2044 tied the sorting behavior to thenameproperty of a column. Thenameof the severity column changed frommax severitytoseverityif the aggregation interval was changed to 'Show all', so if the table was being sorted on the severity column, a change to thenameof the column would break the sorting behavior.With changes to the props of an
EuiInMemoryTableafter first render not being recommended, this PR fixes thenameof the column toseverityirrespective of the aggregation interval setting.Also removes the
sortableprop from the Actions column which was causing console errors as this property should not be provided toEuiInMemoryTablefor columns without afieldprop.Checklist
For maintainers
This includes a feature addition or change that requires a release note and was labeled appropriatelyFixes #40435