Skip to content

(Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div> #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippBaranovskiy merged 5 commits into from
Jun 17, 2019
Merged

(Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div> #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
320a969
drawer heading fix
PhilippBaranovskiy Jun 13, 2019
d8b6be9
update CHANGELOG
PhilippBaranovskiy Jun 13, 2019
3b55788
Apply suggestions from code review
PhilippBaranovskiy Jun 13, 2019
c7a5bc6
Update CHANGELOG
PhilippBaranovskiy Jun 13, 2019
0150dd5
Merge branch 'master' into 2039
PhilippBaranovskiy Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Added `magnet` glyph to `EuiIcon` ([2010](https://github.com/elastic/eui/pull/2010))
- Changed `logoAWS` SVG in `EuiIcon` to work better in dark mode ([#2036](https://github.com/elastic/eui/pull/2036))
- Converted toast components to TypeScript ([#2032](https://github.com/elastic/eui/pull/2032))
- Changed `EuiNavDrawerFlyout` title from `h5` to `div` ([#2040](https://github.com/elastic/eui/pull/2040))

**Bug fixes**

Expand Down
2 changes: 1 addition & 1 deletion src/components/nav_drawer/nav_drawer_flyout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const EuiNavDrawerFlyout = ({
return (
<div className={classes} aria-labelledby="navDrawerFlyoutTitle" {...rest}>
<EuiTitle className="euiNavDrawerFlyout__title" tabIndex="-1" size="xxs">
<h5 id="navDrawerFlyoutTitle">{title}</h5>
<div id="navDrawerFlyoutTitle">{title}</div>
</EuiTitle>
<EuiNavDrawerGroup
className="euiNavDrawerFlyout__listGroup"
Expand Down