Skip to content

[Kibana] Fix Flyout scrolling#39063

Merged
Kerry350 merged 2 commits intoelastic:masterfrom
Kerry350:37699-amend-flyout-style
Jun 19, 2019
Merged

[Kibana] Fix Flyout scrolling#39063
Kerry350 merged 2 commits intoelastic:masterfrom
Kerry350:37699-amend-flyout-style

Conversation

@Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Jun 17, 2019

Summary

This issue was originally picked up here. The core part of the fix has been merged in the EUI Repo. This is a followup style amendment to the legacy .header-global-wrapper + .app-wrapper:not(.hidden-chrome) .euiFlyout selector.

Checklist

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, thanks for using calc on that.

As for the PR labels, I'd remove the release_note:fix for release_note:fix:skip since this doesn't contain the actual fix because we're waiting for EUI to get updated to ^12.0.0. But if you do merge this, be sure to apply the correct 7.x label.

@Kerry350 Kerry350 added v7.3.0 release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jun 19, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Kerry350 Kerry350 merged commit 0e22e51 into elastic:master Jun 19, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants