[Kibana] Fix Flyout scrolling#39063
Merged
Kerry350 merged 2 commits intoelastic:masterfrom Jun 19, 2019
Merged
Conversation
Contributor
💚 Build Succeeded |
cchaos
approved these changes
Jun 18, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Change LGTM, thanks for using calc on that.
As for the PR labels, I'd remove the release_note:fix for release_note:fix:skip since this doesn't contain the actual fix because we're waiting for EUI to get updated to ^12.0.0. But if you do merge this, be sure to apply the correct 7.x label.
Contributor
💚 Build Succeeded |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Jun 19, 2019
Kerry350
added a commit
that referenced
this pull request
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This issue was originally picked up here. The core part of the fix has been merged in the EUI Repo. This is a followup style amendment to the legacy
.header-global-wrapper + .app-wrapper:not(.hidden-chrome) .euiFlyoutselector.Checklist