Skip to content

[babel] remove @babel/polyfill, make core-js devDep #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalger merged 9 commits into from
Jun 7, 2019
Merged

[babel] remove @babel/polyfill, make core-js devDep #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2fede0e
[babel] remove @babel/polyfill, make core-js devDep
May 30, 2019
96cc69e
add changelog entry
May 30, 2019
cf1cefc
Merge branch 'master' of github.com:elastic/eui into remove-core-js-prod
May 31, 2019
44fab99
truthy env var for better logics, apply broadly
May 31, 2019
434858e
Merge branch 'master' of github.com:elastic/eui into remove-core-js-prod
Jun 3, 2019
b883405
keep polyfills in massive pre-bundled build
Jun 3, 2019
27c39f4
Merge branch 'master' of github.com:elastic/eui into remove-core-js-prod
Jun 6, 2019
0bec5cb
move changelog item to master
Jun 6, 2019
c0fb6d8
Merge branch 'master' into remove-core-js-prod
Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = {
"Safari 7" // for PhantomJS support
]
},
"useBuiltIns": "usage",
"useBuiltIns": process.env.NO_COREJS_POLYFILL ? false : "usage",
"modules": process.env.BABEL_MODULES ? process.env.BABEL_MODULES : "commonjs" // babel's default is commonjs
}],
"@babel/typescript",
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- Fixed `EuiCallOut` header icon alignment ([#2006](https://github.com/elastic/eui/pull/2006))

**Breaking changes**

- Removed explicit dependency on `core-js`, but a global polyfill like `core-js@3` is still required ([#1982](https://github.com/elastic/eui/pull/1982))

## [`11.3.1`](https://github.com/elastic/eui/tree/v11.3.1)

**Bug fixes**
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"@types/numeral": "^0.0.25",
"@types/react-beautiful-dnd": "^10.1.0",
"classnames": "^2.2.5",
"core-js": "^2.5.1",
"highlight.js": "^9.12.0",
"html": "^1.0.0",
"keymirror": "^0.1.1",
Expand All @@ -69,7 +68,6 @@
"@babel/plugin-proposal-class-properties": "^7.1.0",
"@babel/plugin-proposal-object-rest-spread": "^7.0.0",
"@babel/plugin-syntax-dynamic-import": "^7.2.0",
"@babel/polyfill": "^7.0.0",
"@babel/preset-env": "^7.1.0",
"@babel/preset-react": "^7.0.0",
"@babel/preset-typescript": "^7.1.0",
Expand Down Expand Up @@ -105,6 +103,7 @@
"chokidar": "^1.7.0",
"chromedriver": "2.37.0",
"circular-dependency-plugin": "^5.0.2",
"core-js": "^2.5.1",
"cross-env": "^5.2.0",
"css-loader": "^0.28.7",
"cssnano": "^4.0.5",
Expand Down
18 changes: 13 additions & 5 deletions scripts/compile-eui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,19 @@ function compileLib() {
console.log('Compiling src/ to es/ and lib/');

// Run all code (com|trans)pilation through babel (ESNext JS & TypeScript)
execSync(
'babel --quiet --out-dir=es --extensions .js,.ts,.tsx --ignore "**/webpack.config.js,**/*.test.js,**/*.d.ts" src',
{ env: { ...this.process.env, BABEL_MODULES: false } }
);
execSync('babel --quiet --out-dir=lib --extensions .js,.ts,.tsx --ignore "**/webpack.config.js,**/*.test.js,**/*.d.ts" src');
execSync('babel --quiet --out-dir=es --extensions .js,.ts,.tsx --ignore "**/webpack.config.js,**/*.test.js,**/*.d.ts" src', {
env: {
...process.env,
BABEL_MODULES: false,
NO_COREJS_POLYFILL: true,
}
});
execSync('babel --quiet --out-dir=lib --extensions .js,.ts,.tsx --ignore "**/webpack.config.js,**/*.test.js,**/*.d.ts" src', {
env: {
...process.env,
NO_COREJS_POLYFILL: true,
}
});

console.log(chalk.green('✔ Finished compiling src/'));

Expand Down
15 changes: 1 addition & 14 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,14 +710,6 @@
"@babel/helper-regex" "^7.0.0"
regexpu-core "^4.1.3"

"@babel/polyfill@^7.0.0":
version "7.0.0"
resolved "https://registry.yarnpkg.com/@babel/polyfill/-/polyfill-7.0.0.tgz#c8ff65c9ec3be6a1ba10113ebd40e8750fb90bff"
integrity sha512-dnrMRkyyr74CRelJwvgnnSUDh2ge2NCTyHVwpOdvRMHtJUyxLtMAfhBN3s64pY41zdw0kgiLPh6S20eb1NcX6Q==
dependencies:
core-js "^2.5.7"
regenerator-runtime "^0.11.1"

"@babel/preset-env@^7.1.0":
version "7.1.0"
resolved "https://registry.yarnpkg.com/@babel/preset-env/-/preset-env-7.1.0.tgz#e67ea5b0441cfeab1d6f41e9b5c79798800e8d11"
Expand Down Expand Up @@ -3496,11 +3488,6 @@ core-js@^2.4.0, core-js@^2.4.1, core-js@^2.5.1:
resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.5.3.tgz#8acc38345824f16d8365b7c9b4259168e8ed603e"
integrity sha1-isw4NFgk8W2DZbfJtCWRaOjtYD4=

core-js@^2.5.7:
version "2.5.7"
resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.5.7.tgz#f972608ff0cead68b841a16a932d0b183791814e"
integrity sha512-RszJCAxg/PP6uzXVXL6BsxSXx/B05oJAQ2vkJRjyjrEcNVycaqOmNb5OTxZPE3xa5gwZduqza6L9JOCenh/Ecw==

core-js@^2.6.5:
version "2.6.5"
resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.6.5.tgz#44bc8d249e7fb2ff5d00e0341a7ffb94fbf67895"
Expand Down Expand Up @@ -12339,7 +12326,7 @@ regenerate@^1.4.0:
resolved "https://registry.yarnpkg.com/regenerate/-/regenerate-1.4.0.tgz#4a856ec4b56e4077c557589cae85e7a4c8869a11"
integrity sha512-1G6jJVDWrt0rK99kBjvEtziZNCICAuvIPkSiUFIQxVP06RCVpq3dmDo2oi6ABpYaDYaTRr67BEhL8r1wgEZZKg==

regenerator-runtime@^0.11.0, regenerator-runtime@^0.11.1:
regenerator-runtime@^0.11.0:
version "0.11.1"
resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.11.1.tgz#be05ad7f9bf7d22e056f9726cee5017fbf19e2e9"
integrity sha512-MguG95oij0fC3QV3URf4V2SDYGJhJnJGqvIIgdECeODCT98wSWDAJ94SSuVpYQUoTcGUIL6L4yNB7j1DFFHSBg==
Expand Down