Correct context for ClusterConnManager listener #83035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today `ClusterConnectionManager#connectToNode` completes its listeners in the thread context in which the connection completes, which may not be the correct context if there are multiple concurrent connection attempts. With this commit we make sure to complete each listener in the context in which it was passed to the corresponding call to `connectToNode`.
DaveCTurner
added
>bug
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Contributor
|
@elasticmachine please run elasticsearch-ci/rest-compatibility |
Contributor
Author
|
#83170 will fix the failure @elasticmachine please run elasticsearch-ci/part-1 |
original-brownbear
approved these changes
Jan 26, 2022
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM
Are we sure about backporting to 7.17 though? I can't think of a bug this would cause?
DaveCTurner
deleted the
2022-01-25-ClusterConnectionManager-thread-context
branch
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
Yeah it might not be a real bug, at least not right now, but also not a controversial bugfix so worth the backport IMO. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 26, 2022
Today `ClusterConnectionManager#connectToNode` completes its listeners in the thread context in which the connection completes, which may not be the correct context if there are multiple concurrent connection attempts. With this commit we make sure to complete each listener in the context in which it was passed to the corresponding call to `connectToNode`. Co-authored-by: ievgen.degtiarenko <[email protected]>
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 26, 2022
Today `ClusterConnectionManager#connectToNode` completes its listeners in the thread context in which the connection completes, which may not be the correct context if there are multiple concurrent connection attempts. With this commit we make sure to complete each listener in the context in which it was passed to the corresponding call to `connectToNode`. Co-authored-by: ievgen.degtiarenko <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Correct context for ClusterConnManager listener (#83035) Today `ClusterConnectionManager#connectToNode` completes its listeners in the thread context in which the connection completes, which may not be the correct context if there are multiple concurrent connection attempts. With this commit we make sure to complete each listener in the context in which it was passed to the corresponding call to `connectToNode`. Co-authored-by: ievgen.degtiarenko <[email protected]> * Missing import * Missed one Co-authored-by: ievgen.degtiarenko <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Correct context for ClusterConnManager listener (#83035) Today `ClusterConnectionManager#connectToNode` completes its listeners in the thread context in which the connection completes, which may not be the correct context if there are multiple concurrent connection attempts. With this commit we make sure to complete each listener in the context in which it was passed to the corresponding call to `connectToNode`. Co-authored-by: ievgen.degtiarenko <[email protected]> * Missing import * Fix up tests Co-authored-by: ievgen.degtiarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
ClusterConnectionManager#connectToNodecompletes its listenersin the thread context in which the connection completes, which may not
be the correct context if there are multiple concurrent connection
attempts. With this commit we make sure to complete each listener in the
context in which it was passed to the corresponding call to
connectToNode.