Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

The mutation function would rarely fail to mutate the input object. This
commit fixes that.

Relates #82689

The mutation function would rarely fail to mutate the input object. This
commit fixes that.

Relates elastic#82689
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v8.0.0 v8.1.0 v7.17.1 labels Jan 26, 2022
@DaveCTurner DaveCTurner requested a review from grcevski January 26, 2022 17:14
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 26, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@DaveCTurner
Copy link
Contributor Author

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@DaveCTurner DaveCTurner merged commit 847dd43 into elastic:master Jan 27, 2022
@DaveCTurner DaveCTurner deleted the 2022-01-26-NodeMetadataTests#testEqualsHashcodeSerialization branch January 27, 2022 09:06
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jan 27, 2022
The mutation function would rarely fail to mutate the input object. This
commit fixes that.

Relates elastic#82689
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jan 27, 2022
The mutation function would rarely fail to mutate the input object. This
commit fixes that.

Relates elastic#82689
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.17

elasticsearchmachine pushed a commit that referenced this pull request Jan 27, 2022
The mutation function would rarely fail to mutate the input object. This
commit fixes that.

Relates #82689
elasticsearchmachine pushed a commit that referenced this pull request Jan 27, 2022
…#83194)

* Fix NodeMetadataTests#testEqualsHashcodeSerialization (#83170)

The mutation function would rarely fail to mutate the input object. This
commit fixes that.

Relates #82689

* Old-skool switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.17.0 v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants