Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

Today ClusterConnectionManager#connectToNode completes its listeners
in the thread context in which the connection completes, which may not
be the correct context if there are multiple concurrent connection
attempts. With this commit we make sure to complete each listener in the
context in which it was passed to the corresponding call to
connectToNode.

Co-authored-by: ievgen.degtiarenko [email protected]

Today `ClusterConnectionManager#connectToNode` completes its listeners
in the thread context in which the connection completes, which may not
be the correct context if there are multiple concurrent connection
attempts. With this commit we make sure to complete each listener in the
context in which it was passed to the corresponding call to
`connectToNode`.

Co-authored-by: ievgen.degtiarenko <[email protected]>
@DaveCTurner DaveCTurner added backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v7.17.1 labels Jan 26, 2022
@DaveCTurner
Copy link
Contributor Author

Failure looks transient:

11:07:27 A problem occurred configuring project ':build-tools'.
11:07:27 > Could not resolve all files for configuration ':build-tools:classpath'.
11:07:27    > Could not download maven-model-3.6.2.jar (org.apache.maven:maven-model:3.6.2)
11:07:27       > Could not get resource 'https://plugins.gradle.org/m2/org/apache/maven/maven-model/3.6.2/maven-model-3.6.2.jar'.
11:07:27          > Could not HEAD 'https://plugins.gradle.org/m2/org/apache/maven/maven-model/3.6.2/maven-model-3.6.2.jar'.
11:07:27             > Read timed out
11:07:27    > Could not download apache-rat-0.11.jar (org.apache.rat:apache-rat:0.11)
11:07:27       > Could not get resource 'https://plugins.gradle.org/m2/org/apache/rat/apache-rat/0.11/apache-rat-0.11.jar'.
11:07:27          > Could not HEAD 'https://plugins.gradle.org/m2/org/apache/rat/apache-rat/0.11/apache-rat-0.11.jar'.
11:07:27             > Read timed out
11:07:27    > Could not download apache-rat-tasks-0.11.jar (org.apache.rat:apache-rat-tasks:0.11)
11:07:27       > Could not get resource 'https://plugins.gradle.org/m2/org/apache/rat/apache-rat-tasks/0.11/apache-rat-tasks-0.11.jar'.
11:07:27          > Could not HEAD 'https://plugins.gradle.org/m2/org/apache/rat/apache-rat-tasks/0.11/apache-rat-tasks-0.11.jar'.
11:07:27             > Read timed out
11:07:27    > Could not download apache-rat-core-0.11.jar (org.apache.rat:apache-rat-core:0.11)
11:07:27       > Could not get resource 'https://plugins.gradle.org/m2/org/apache/rat/apache-rat-core/0.11/apache-rat-core-0.11.jar'.
11:07:27          > Could not HEAD 'https://plugins.gradle.org/m2/org/apache/rat/apache-rat-core/0.11/apache-rat-core-0.11.jar'.
11:07:27             > Read timed out
11:07:27    > Could not download commons-cli-1.2.jar (commons-cli:commons-cli:1.2)
11:07:27       > Could not get resource 'https://plugins.gradle.org/m2/commons-cli/commons-cli/1.2/commons-cli-1.2.jar'.
11:07:27          > Could not HEAD 'https://plugins.gradle.org/m2/commons-cli/commons-cli/1.2/commons-cli-1.2.jar'.
11:07:27             > Read timed out

@elasticmachine please run elasticsearch-ci/packaging-tests-windows-sample

@elasticsearchmachine elasticsearchmachine merged commit 1f1046d into elastic:7.17 Jan 27, 2022
@DaveCTurner DaveCTurner deleted the 2022-01-26-backport-83035-7.17 branch January 27, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants