[DOCS] Update the number detection mapping rules for float#66911
Closed
RickyLau wants to merge 1 commit intoelastic:masterfrom
Closed
[DOCS] Update the number detection mapping rules for float#66911RickyLau wants to merge 1 commit intoelastic:masterfrom
RickyLau wants to merge 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
jimczi
requested changes
Jan 4, 2021
javanna
changed the title
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Jan 5, 2021
Contributor
|
@RickyLau are you planning to accept the suggested change? If so we can then merge your change. Thanks! |
Contributor
Author
I accept this suggestion. |
Contributor
|
thanks @RickyLau , could you go and accept the suggestion above so the change becomes a commit and we can merge it in? Unfortunately a comment is not enough to make it a commit ;) |
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 11, 2021
* Changes for dynamic templates. * Clarifying language around dynamic:true and dynamic:runtime. * Clarifying edits and some restructuring. * Overhauling the Mapping page. * Incorporating changes from #66911. * Reworking mapping page to focus on dynamic vs. explicit mapping. * Reordering to fix test failure. * Further clarifying mapping page. * Reordering sections, adding headings to examples, and other clarifications. * Incorporating review feedback. * Adding description of for Painless script.
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 11, 2021
* Changes for dynamic templates. * Clarifying language around dynamic:true and dynamic:runtime. * Clarifying edits and some restructuring. * Overhauling the Mapping page. * Incorporating changes from #66911. * Reworking mapping page to focus on dynamic vs. explicit mapping. * Reordering to fix test failure. * Further clarifying mapping page. * Reordering sections, adding headings to examples, and other clarifications. * Incorporating review feedback. * Adding description of for Painless script. * Minor revisions.
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 11, 2021
* Changes for dynamic templates. * Clarifying language around dynamic:true and dynamic:runtime. * Clarifying edits and some restructuring. * Overhauling the Mapping page. * Incorporating changes from #66911. * Reworking mapping page to focus on dynamic vs. explicit mapping. * Reordering to fix test failure. * Further clarifying mapping page. * Reordering sections, adding headings to examples, and other clarifications. * Incorporating review feedback. * Adding description of for Painless script. * Minor revisions.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the number detection mapping rules for floating-point values in JSON
Closes #66910