[DOCS] Runtime fields improvements#66530
Merged
lockewritesdocs merged 13 commits intoelastic:masterfrom Jan 11, 2021
Merged
Conversation
javanna
approved these changes
Dec 21, 2020
Contributor
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
left a tiny comment, LGTM otherwise so far. I think that this is a really good step forward.
Contributor
Author
|
@elasticmachine update branch |
javanna
reviewed
Jan 5, 2021
javanna
reviewed
Jan 5, 2021
javanna
reviewed
Jan 5, 2021
Contributor
Author
|
@elasticmachine update branch |
javanna
approved these changes
Jan 7, 2021
Contributor
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
I left some comments, LGTM besides those
javanna
reviewed
Jan 11, 2021
Contributor
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
I left a couple more comments
lockewritesdocs
added
:Search Foundations/Mapping
elasticmachine
added
Team:Search
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 11, 2021
* Changes for dynamic templates. * Clarifying language around dynamic:true and dynamic:runtime. * Clarifying edits and some restructuring. * Overhauling the Mapping page. * Incorporating changes from #66911. * Reworking mapping page to focus on dynamic vs. explicit mapping. * Reordering to fix test failure. * Further clarifying mapping page. * Reordering sections, adding headings to examples, and other clarifications. * Incorporating review feedback. * Adding description of for Painless script. * Minor revisions.
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 11, 2021
* Changes for dynamic templates. * Clarifying language around dynamic:true and dynamic:runtime. * Clarifying edits and some restructuring. * Overhauling the Mapping page. * Incorporating changes from #66911. * Reworking mapping page to focus on dynamic vs. explicit mapping. * Reordering to fix test failure. * Further clarifying mapping page. * Reordering sections, adding headings to examples, and other clarifications. * Incorporating review feedback. * Adding description of for Painless script. * Minor revisions.
This was referenced Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements and enhancements from changes in #66194.