Skip to content

Comments

[DOCS] Add dynamic runtime fields to docs#66194

Merged
lockewritesdocs merged 4 commits intoelastic:masterfrom
lockewritesdocs:docs__dynamic-runtime-fields
Dec 14, 2020
Merged

[DOCS] Add dynamic runtime fields to docs#66194
lockewritesdocs merged 4 commits intoelastic:masterfrom
lockewritesdocs:docs__dynamic-runtime-fields

Conversation

@lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Dec 10, 2020 •
edited
Loading

Adds descriptions and usage of dynamic runtime fields introduced in #65489:

  • Introduces the runtime value for the dynamic parameter
  • Updates the Dynamic mapping page to discuss runtime fields
  • Updates the mapping section of the Runtime fields page to explain dynamic mapping
  • Includes related links between these pages

@lockewritesdocs lockewritesdocs added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 labels Dec 10, 2020
@lockewritesdocs lockewritesdocs self-assigned this Dec 10, 2020
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels Dec 10, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020

Pinging @elastic/es-search (Team:Search)

@lockewritesdocs lockewritesdocs mentioned this pull request Dec 10, 2020
Merged
nik9000
nik9000 reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its already a great improvement! I've left a couple of question about ways maybe it could be even better? I really do wonder if it'd be better in the table on https://elasticsearch_66194.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/dynamic-field-mapping.html was three colunms wide.

nik9000
nik9000 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lockewritesdocs lockewritesdocs merged commit fe54c2f into elastic:master Dec 14, 2020
@lockewritesdocs lockewritesdocs deleted the docs__dynamic-runtime-fields branch December 14, 2020 21:37
@lockewritesdocs lockewritesdocs mentioned this pull request Dec 14, 2020
Merged
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 14, 2020
@jasontedor
Merge remote-tracking branch 'elastic/master' into license-to-autoscale
3abdab8 
* elastic/master: (33 commits)
  Add searchable snapshot cache folder to NodeEnvironment (elastic#66297)
  [DOCS] Add dynamic runtime fields to docs (elastic#66194)
  Add HDFS searchable snapshot integration (elastic#66185)
  Support canceling cross-clusters search requests (elastic#66206)
  Mute testCacheSurviveRestart (elastic#66289)
  Fix cat tasks api params in spec and handler (elastic#66272)
  Snapshot of a searchable snapshot should be empty (elastic#66162)
  [ML] DFA _explain API should not fail when none field is included (elastic#66281)
  Add action to decommission legacy monitoring cluster alerts (elastic#64373)
  move rollup_index param out of RollupActionConfig (elastic#66139)
  Improve FieldFetcher retrieval of fields (elastic#66160)
  Remove unsed fields in `RestAnalyzeAction` (elastic#66215)
  Simplify searchable snapshot CacheKey (elastic#66263)
  Autoscaling remove feature flags (elastic#65973)
  Improve searchable snapshot mount time (elastic#66198)
  [ML] Report cause when datafeed extraction encounters error (elastic#66167)
  Remove suggest reference in some API specs (elastic#66180)
  Fix warning when installing a plugin for different ESversion (elastic#66146)
  [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132)
  [DOCS] Add `require_alias` to Bulk API (elastic#66259)
  ...
lockewritesdocs pushed a commit that referenced this pull request Dec 14, 2020
[DOCS] Add dynamic runtime fields to docs (#66194) (#66304)
9830222 
* [DOCS] Add dynamic runtime fields to docs.

* Clarifying edits and example changes.

* Creating better table and incorporating review comments.

* Change numeral to superscript.
javanna
javanna reviewed Dec 16, 2020
View reviewed changes
javanna
javanna reviewed Dec 16, 2020
View reviewed changes
@javanna
Copy link
Contributor

javanna commented Dec 16, 2020

thanks @lockewritesdocs I left a couple of minor comments that can be addressed as a follow-up if you think they make sense. Also, do you plan on expanding the dynamic template page as a follow-up to document the ability to map fields as runtime from a dynamic template?

@lockewritesdocs lockewritesdocs mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

+1 more reviewer

@javanna javanna javanna left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lockewritesdocs lockewritesdocs

Labels

>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lockewritesdocs @elasticmachine @javanna @nik9000 @jakelandis