Disable auto pretty print for main REST action#4182
Disable auto pretty print for main REST action#4182Paikan wants to merge 1 commit intoelastic:masterfrom Paikan:disable-pretty-print-main-rest-action
Conversation
|
I would not merge it as is as I find it convinient to have it pretty printed by default. That said, if we run http://localhost:9200/?pretty=false it stills display it pretty printed which is a bug to me :-) What do you and others think? |
|
+1 for disable pretty print by default to make it consistent with all other endpoints. |
|
I'm curious what the reasoning is behind disabling it (besides the rest of the APIs don't format by default)? I like it; is it causing issues with anything in particular? |
|
that's the only reason i see: to be consistent with everything else. i'm not sure why it's a big deal - you can add ?pretty=true just as easily. |
|
IMHO this is the first command a new user run. I'd prefer to welcome him nicely. My 0.05 cents. |
|
@dakrone @dadoonet as I said not a big deal or issues here with the default prettification it was only for consitency. I understand your point wanting to give a warmer welcoming to the first command of a new user. I have opened PR #4188 to at least support pretty=false and the line feed in the prettification. Feel free to close this one when you see fit. |
Serverless codebase update because of upstream elasticsearch interface change: elastic#130961
Serverless codebase update because of upstream elasticsearch interface change: elastic#130961
Not a big deal but for the sake of consistency I find it strange that the main REST action is the only one to be auto pretty printed.
If it is on purpose maybe it would be better to at least add the call to the .lfAtEnd() that is called when setting the pretty param to true.