Skip to content

Comments

Create a Builder for TaskTrackingConfig#130961

Merged
DiannaHohensee merged 4 commits intoelastic:mainfrom
DiannaHohensee:2025/07/09/builder-TaskTrackingConfig
Jul 11, 2025
Merged

Create a Builder for TaskTrackingConfig#130961
DiannaHohensee merged 4 commits intoelastic:mainfrom
DiannaHohensee:2025/07/09/builder-TaskTrackingConfig

Conversation

@DiannaHohensee
Copy link
Contributor

@DiannaHohensee DiannaHohensee commented Jul 9, 2025

Code cleanup followup from a comment on another PR. I'll need to update this PR after #130411 is committed.

@DiannaHohensee DiannaHohensee self-assigned this Jul 9, 2025
@DiannaHohensee DiannaHohensee requested a review from a team as a code owner July 9, 2025 22:23
@DiannaHohensee DiannaHohensee added >non-issue :Distributed/Autoscaling Automatically adding or removing nodes in a cluster Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. labels Jul 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jul 9, 2025
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice cleanup, thanks!

@DiannaHohensee DiannaHohensee force-pushed the 2025/07/09/builder-TaskTrackingConfig branch from c012459 to 46ae7cf Compare July 10, 2025 20:47
@DiannaHohensee
Copy link
Contributor Author

Thanks for stopping by for the review, @ldematte. I've merged in some related changes that required another field in the builder. Would you mind approving the one-line change I need in serverless, too? https://github.com/elastic/elasticsearch-serverless/pull/4182

@DiannaHohensee DiannaHohensee merged commit d6c20bd into elastic:main Jul 11, 2025
33 checks passed
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Feb 11, 2026
Serverless codebase update because of upstream elasticsearch interface change: elastic#130961
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Feb 11, 2026
Serverless codebase update because of upstream elasticsearch interface change: elastic#130961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Autoscaling Automatically adding or removing nodes in a cluster >non-issue serverless-linked Added by automation, don't add manually Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants