Handle pretty=false and missing line feed for pretty=true which is the d...#4188
Closed
Paikan wants to merge 1 commit intoelastic:masterfrom
Paikan:change-pretty-print-main-rest-action
Closed
Handle pretty=false and missing line feed for pretty=true which is the d...#4188Paikan wants to merge 1 commit intoelastic:masterfrom Paikan:change-pretty-print-main-rest-action
Paikan wants to merge 1 commit intoelastic:masterfrom
Paikan:change-pretty-print-main-rest-action
Conversation
…e default for main REST action
Member
|
I think this is a much better suggestion, do you agree @dadoonet? If so, I'll go ahead and merge this. |
Contributor
|
@dakrone I agree. That means we need to merge both PR, right? |
Member
|
@dadoonet nope, just this one. I'm on it. |
Member
|
Merged via 00be285, thanks! |
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...efault for main REST action.
Following the debate on #4182 this PR keeps the fact that the main REST action is prettyfied by default but handling the pretty=false parameter and the added line feed in the prettification process.