Skip to content

Ensure we use floats values for rolling upgrade float vectors#144032

Merged
thecoop merged 1 commit intoelastic:mainfrom
thecoop:fix/densevectorupgrade-longs
Mar 11, 2026
Merged

Ensure we use floats values for rolling upgrade float vectors#144032
thecoop merged 1 commit intoelastic:mainfrom
thecoop:fix/densevectorupgrade-longs

Conversation

@thecoop
Copy link
Copy Markdown
Member

@thecoop thecoop commented Mar 11, 2026

Whilst I'm unclear on how the failure in #143796 actually happens, as it's not reproducible, this change ensure the values for float vectors are actually floats so there's no chance they could be reinterpreted by ES at some point

Fixes #143796

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search labels Mar 11, 2026
@elasticsearchmachine elasticsearchmachine added v9.4.0 Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Mar 11, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@thecoop thecoop force-pushed the fix/densevectorupgrade-longs branch from 02cc40a to fe6314e Compare March 11, 2026 15:30
@thecoop thecoop merged commit 7c5688e into elastic:main Mar 11, 2026
33 of 36 checks passed
@thecoop thecoop deleted the fix/densevectorupgrade-longs branch March 11, 2026 16:58
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 11, 2026
…elocations

* upstream/main: (54 commits)
  [ES|QL|DS] Wire parallel parsing into production for text formats (elastic#143997)
  ESQL: Allow EXTERNAL commands be run part of the CsvTests suite (elastic#143970)
  [ESQL] Push stats to external source via metadata (elastic#143940)
  Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats with stats where} elastic#144051
  Refactored SortedNumericDocValuesSyntheticFieldLoader into a Layer (elastic#143912)
  Enable extended doc_values params feature flag in RandomizedRollingUpgradeIT (elastic#143918)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT test {csv-spec:approximation.Approximate stats with sample} elastic#144022
  Ensure we use float values for rolling upgrade float vectors (elastic#144032)
  Remove sensitive info from reindex task description (elastic#143635)
  Fix HistogramUnionState.equals (elastic#143990)
  Use dedicated IndexRouting API in ShardSplittingQuery (elastic#143776)
  Engine/Store DistributedArchitectureGuide doc (elastic#143818)
  Mute org.elasticsearch.snapshots.ConcurrentSnapshotsIT testDeletesAreBatched elastic#144034
  Avoid serializing exceptions as JSON in remote write endpoint (elastic#143987)
  allow testLoadDocSequenceReturnsCorrectResultsText to circuit break, it happens in serverless occasionally (elastic#144023)
  [ESQL] Adds memory accounting to GroupedLimitOperator (elastic#143941)
  Adjust ESIntegTestCase.getLiveDocs method to account for pruned sequence numbers (elastic#143999)
  Support target bucket count in `TBUCKET` with explicit from/to date range (elastic#142747)
  TSDBDocValuesFormatSingleNodeTests with and without synthetic id (elastic#144002)
  Fix circuit breaker leak in BreakingTDigestHolder (elastic#143873)
  ...
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] DenseVectorRollingUpgradeIT class failing

3 participants