Skip to content

Enable extended doc_values params feature flag in RandomizedRollingUpgradeIT#143918

Merged
Kubik42 merged 1 commit intoelastic:mainfrom
Kubik42:test-fix
Mar 11, 2026
Merged

Enable extended doc_values params feature flag in RandomizedRollingUpgradeIT#143918
Kubik42 merged 1 commit intoelastic:mainfrom
Kubik42:test-fix

Conversation

@Kubik42
Copy link
Copy Markdown
Contributor

@Kubik42 Kubik42 commented Mar 10, 2026 •
edited
Loading

Fixes #142048.

The reason for the test occasionally failing is due to this function here. Because the EXTENDED_DOC_VALUES_PARAMS feature flag and the STORE_HIGH_CARDINALITY_KEYWORDS_IN_BINARY_DOC_VALUES Mapper feature are decoupled, the function incorrectly assumes that extended doc_values can be generated, while the old cluster doesn't support them. This results in the following error:

RandomizedRollingUpgradeIT > testIndexingSyntheticSource FAILED
    org.elasticsearch.client.ResponseException: method [PUT], host [http://[::1]:33063], URI [/test-index-synthetic-1], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"Failed to parse mapping: Could not convert [doc_values] to boolean"}],"type":"mapper_parsing_exception","reason":"Failed to parse mapping: Could not convert [doc_values] to boolean","caused_by":{"type":"illegal_argument_exception","reason":"Could not convert [doc_values] to boolean","caused_by":{"type":"illegal_argument_exception","reason":"Failed to parse value [{cardinality=high}] as only [true] or [false] are allowed."}}},"status":400}
        at __randomizedtesting.SeedInfo.seed([9617804EE6C9E568:7DFFAC6E94878DDE]:0)
        at app//org.elasticsearch.client.RestClient.convertResponse(RestClient.java:351)
        at app//org.elasticsearch.client.RestClient.performRequest(RestClient.java:317)
        at app//org.elasticsearch.client.RestClient.performRequest(RestClient.java:292)
        at app//org.elasticsearch.test.rest.ESRestTestCase.createIndex(ESRestTestCase.java:2060)
        at app//org.elasticsearch.test.rest.ESRestTestCase.createIndex(ESRestTestCase.java:2018)
        at app//org.elasticsearch.test.rest.ESRestTestCase.createIndex(ESRestTestCase.java:2013)
        at app//org.elasticsearch.test.rest.ESRestTestCase.createIndex(ESRestTestCase.java:2009)
        at app//org.elasticsearch.xpack.logsdb.RandomizedRollingUpgradeIT.createIndex(RandomizedRollingUpgradeIT.java:110)
        at app//org.elasticsearch.xpack.logsdb.RandomizedRollingUpgradeIT.testIndexing(RandomizedRollingUpgradeIT.java:130)
        at app//org.elasticsearch.xpack.logsdb.RandomizedRollingUpgradeIT.testIndexingSyntheticSource(RandomizedRollingUpgradeIT.java:157)

@Kubik42 Kubik42 added >non-issue Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings labels Mar 10, 2026
@Kubik42 Kubik42 changed the title Fixed flaky test RandomizedRollingUpgradeIT Enable extended doc_values params feature flag in RandomizedRollingUpgradeIT Mar 10, 2026
@Kubik42 Kubik42 marked this pull request as ready for review March 10, 2026 23:19
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Mar 10, 2026

Pinging @elastic/es-storage-engine (Team:StorageEngine)

jordan-powers
jordan-powers approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tracking this down @Kubik42 !

martijnvg
martijnvg approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kubik42 Kubik42 merged commit 82d2ec8 into elastic:main Mar 11, 2026
37 checks passed
@Kubik42 Kubik42 deleted the test-fix branch March 11, 2026 17:47
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 11, 2026
@szybia
Merge remote-tracking branch 'upstream/main' into list-reindex-with-r…
59db848 
…elocations

* upstream/main: (54 commits)
  [ES|QL|DS] Wire parallel parsing into production for text formats (elastic#143997)
  ESQL: Allow EXTERNAL commands be run part of the CsvTests suite (elastic#143970)
  [ESQL] Push stats to external source via metadata (elastic#143940)
  Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats with stats where} elastic#144051
  Refactored SortedNumericDocValuesSyntheticFieldLoader into a Layer (elastic#143912)
  Enable extended doc_values params feature flag in RandomizedRollingUpgradeIT (elastic#143918)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT test {csv-spec:approximation.Approximate stats with sample} elastic#144022
  Ensure we use float values for rolling upgrade float vectors (elastic#144032)
  Remove sensitive info from reindex task description (elastic#143635)
  Fix HistogramUnionState.equals (elastic#143990)
  Use dedicated IndexRouting API in ShardSplittingQuery (elastic#143776)
  Engine/Store DistributedArchitectureGuide doc (elastic#143818)
  Mute org.elasticsearch.snapshots.ConcurrentSnapshotsIT testDeletesAreBatched elastic#144034
  Avoid serializing exceptions as JSON in remote write endpoint (elastic#143987)
  allow testLoadDocSequenceReturnsCorrectResultsText to circuit break, it happens in serverless occasionally (elastic#144023)
  [ESQL] Adds memory accounting to GroupedLimitOperator (elastic#143941)
  Adjust ESIntegTestCase.getLiveDocs method to account for pruned sequence numbers (elastic#143999)
  Support target bucket count in `TBUCKET` with explicit from/to date range (elastic#142747)
  TSDBDocValuesFormatSingleNodeTests with and without synthetic id (elastic#144002)
  Fix circuit breaker leak in BreakingTDigestHolder (elastic#143873)
  ...
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request Mar 11, 2026
@Kubik42 @jdconrad
Enable extended doc_values params feature flag in RandomizedRollingUp…
c4bc35f 
…gradeIT (elastic#143918)
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request Mar 11, 2026
@Kubik42 @jdconrad
Enable extended doc_values params feature flag in RandomizedRollingUp…
37a3098 
…gradeIT (elastic#143918)
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request Mar 11, 2026
@Kubik42 @jdconrad
Enable extended doc_values params feature flag in RandomizedRollingUp…
4025ce8 
…gradeIT (elastic#143918)
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request Mar 11, 2026
@Kubik42 @jdconrad
Enable extended doc_values params feature flag in RandomizedRollingUp…
9f3d1d1 
…gradeIT (elastic#143918)
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
@Kubik42 @michalborek
Enable extended doc_values params feature flag in RandomizedRollingUp…
ccc49f0 
…gradeIT (elastic#143918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

@jordan-powers jordan-powers jordan-powers approved these changes

Assignees

No one assigned

Labels

>non-issue :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RandomizedRollingUpgradeIT > testIndexingSyntheticSource fails with IllegalArgumentException

4 participants

@Kubik42 @elasticsearchmachine @martijnvg @jordan-powers