ESQL: Allow EXTERNAL commands be run part of the CsvTests suite#143970
Merged
bpintea merged 4 commits intoelastic:mainfrom Mar 11, 2026
Merged
ESQL: Allow EXTERNAL commands be run part of the CsvTests suite#143970bpintea merged 4 commits intoelastic:mainfrom
bpintea merged 4 commits intoelastic:mainfrom
Conversation
bpintea
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 11, 2026
…elocations * upstream/main: (54 commits) [ES|QL|DS] Wire parallel parsing into production for text formats (elastic#143997) ESQL: Allow EXTERNAL commands be run part of the CsvTests suite (elastic#143970) [ESQL] Push stats to external source via metadata (elastic#143940) Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats with stats where} elastic#144051 Refactored SortedNumericDocValuesSyntheticFieldLoader into a Layer (elastic#143912) Enable extended doc_values params feature flag in RandomizedRollingUpgradeIT (elastic#143918) Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT test {csv-spec:approximation.Approximate stats with sample} elastic#144022 Ensure we use float values for rolling upgrade float vectors (elastic#144032) Remove sensitive info from reindex task description (elastic#143635) Fix HistogramUnionState.equals (elastic#143990) Use dedicated IndexRouting API in ShardSplittingQuery (elastic#143776) Engine/Store DistributedArchitectureGuide doc (elastic#143818) Mute org.elasticsearch.snapshots.ConcurrentSnapshotsIT testDeletesAreBatched elastic#144034 Avoid serializing exceptions as JSON in remote write endpoint (elastic#143987) allow testLoadDocSequenceReturnsCorrectResultsText to circuit break, it happens in serverless occasionally (elastic#144023) [ESQL] Adds memory accounting to GroupedLimitOperator (elastic#143941) Adjust ESIntegTestCase.getLiveDocs method to account for pruned sequence numbers (elastic#143999) Support target bucket count in `TBUCKET` with explicit from/to date range (elastic#142747) TSDBDocValuesFormatSingleNodeTests with and without synthetic id (elastic#144002) Fix circuit breaker leak in BreakingTDigestHolder (elastic#143873) ...
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…tic#143970) This allows `.csv-spec` files be run part of the `CsvTests` suite, also when they contain the `EXTERNAL` command. The tests must use `EXTERNAL "{{<CSV file>}}" ...` format, where `<CSV file>` is one of the files used by "regular"/other CsvTests or IT tests. The `{{...}}` pattern is replaced with a `"file://path/<CSV file>"` and read with the recently added esql-datasource-http and -csv plugins logic. Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as `...,[foo,bar],...` besides the `...,"[foo,bar]",...` (but also `...,["foo","bar"],...`). Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection. 🤖 Developed AI-assisted.
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…tic#143970) This allows `.csv-spec` files be run part of the `CsvTests` suite, also when they contain the `EXTERNAL` command. The tests must use `EXTERNAL "{{<CSV file>}}" ...` format, where `<CSV file>` is one of the files used by "regular"/other CsvTests or IT tests. The `{{...}}` pattern is replaced with a `"file://path/<CSV file>"` and read with the recently added esql-datasource-http and -csv plugins logic. Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as `...,[foo,bar],...` besides the `...,"[foo,bar]",...` (but also `...,["foo","bar"],...`). Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection. 🤖 Developed AI-assisted.
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…tic#143970) This allows `.csv-spec` files be run part of the `CsvTests` suite, also when they contain the `EXTERNAL` command. The tests must use `EXTERNAL "{{<CSV file>}}" ...` format, where `<CSV file>` is one of the files used by "regular"/other CsvTests or IT tests. The `{{...}}` pattern is replaced with a `"file://path/<CSV file>"` and read with the recently added esql-datasource-http and -csv plugins logic. Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as `...,[foo,bar],...` besides the `...,"[foo,bar]",...` (but also `...,["foo","bar"],...`). Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection. 🤖 Developed AI-assisted.
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…tic#143970) This allows `.csv-spec` files be run part of the `CsvTests` suite, also when they contain the `EXTERNAL` command. The tests must use `EXTERNAL "{{<CSV file>}}" ...` format, where `<CSV file>` is one of the files used by "regular"/other CsvTests or IT tests. The `{{...}}` pattern is replaced with a `"file://path/<CSV file>"` and read with the recently added esql-datasource-http and -csv plugins logic. Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as `...,[foo,bar],...` besides the `...,"[foo,bar]",...` (but also `...,["foo","bar"],...`). Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection. 🤖 Developed AI-assisted.
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…tic#143970) This allows `.csv-spec` files be run part of the `CsvTests` suite, also when they contain the `EXTERNAL` command. The tests must use `EXTERNAL "{{<CSV file>}}" ...` format, where `<CSV file>` is one of the files used by "regular"/other CsvTests or IT tests. The `{{...}}` pattern is replaced with a `"file://path/<CSV file>"` and read with the recently added esql-datasource-http and -csv plugins logic. Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as `...,[foo,bar],...` besides the `...,"[foo,bar]",...` (but also `...,["foo","bar"],...`). Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection. 🤖 Developed AI-assisted.
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
…tic#143970) This allows `.csv-spec` files be run part of the `CsvTests` suite, also when they contain the `EXTERNAL` command. The tests must use `EXTERNAL "{{<CSV file>}}" ...` format, where `<CSV file>` is one of the files used by "regular"/other CsvTests or IT tests. The `{{...}}` pattern is replaced with a `"file://path/<CSV file>"` and read with the recently added esql-datasource-http and -csv plugins logic. Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as `...,[foo,bar],...` besides the `...,"[foo,bar]",...` (but also `...,["foo","bar"],...`). Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection. 🤖 Developed AI-assisted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
.csv-specfiles be run part of theCsvTestssuite, also when they contain theEXTERNALcommand.The tests must use
EXTERNAL "{{<CSV file>}}" ...format, where<CSV file>is one of the files used by "regular"/other CsvTests or IT tests. The{{...}}pattern is replaced with a"file://path/<CSV file>"and read with the recently added esql-datasource-http and -csv plugins logic.Part of the change, "esql-datasource-csv" has been updated to support the format of our CSV data files. Most notably, MVs can now be specified as
...,[foo,bar],...besides the...,"[foo,bar]",...(but also...,["foo","bar"],...).Also, the iceberg tests have been moved into the respective plugin -- only CsvTests-"executable" .csv-spec files should now be allowed under esql plugin's QA fixtures collection.
🤖 Developed AI-assisted.