Skip to content

Correctly include endpoint id in log msg in AuthorizationPoller#143743

Merged
dimitris-athanasiou merged 1 commit intoelastic:mainfrom
dimitris-athanasiou:fix-log-message-in-auth-poller
Mar 6, 2026
Merged

Correctly include endpoint id in log msg in AuthorizationPoller#143743
dimitris-athanasiou merged 1 commit intoelastic:mainfrom
dimitris-athanasiou:fix-log-message-in-auth-poller

Conversation

@dimitris-athanasiou
Copy link
Copy Markdown
Contributor

@dimitris-athanasiou dimitris-athanasiou commented Mar 6, 2026

This fixes debug log messages added in #143567 where the endpoint id is not correctly included.

Summary by CodeRabbit

  • Style
    • Updated logging format consistency in authorization-related debug messages.

This fixes debug log messages added in elastic#143567 where the endpoint
id is not correctly included.
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/search-inference-team (Team:Search - Inference)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: dc6c9375-7ae9-4826-a41e-c4f7ecbdd7e7

📥 Commits

Reviewing files that changed from the base of the PR and between bcc0ae3 and 0cb15e3.

📒 Files selected for processing (1)
  • x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/authorization/AuthorizationPoller.java

📝 Walkthrough

Walkthrough

Three debug log messages in the AuthorizationPoller's shouldPersistEndpoint method were updated to replace {} format placeholders with %s format specifiers in logging statements. No functional logic changes were made.

Changes

Cohort / File(s) Summary
Logging Format Updates
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/authorization/AuthorizationPoller.java
Updated three debug log message format placeholders from {} to %s in shouldPersistEndpoint method when endpoint does not exist, fingerprint has changed, or version is higher.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through logs so bright,
Changing brackets—{} to %s in sight,
No logic bent, just format's dance,
A polish fine, a cleaning glance! ✨🐰

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing log message format to correctly include endpoint id using proper placeholder syntax in AuthorizationPoller.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dimitris-athanasiou dimitris-athanasiou merged commit 9db3d75 into elastic:main Mar 6, 2026
36 checks passed
@dimitris-athanasiou dimitris-athanasiou deleted the fix-log-message-in-auth-poller branch March 6, 2026 15:28
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 6, 2026
…locations

* upstream/main: (153 commits)
  ES|QL: Update docs for TOP_SNIPPETS and DECAY (elastic#143739)
  Correctly include endpoint id in log msg in AuthorizationPoller (elastic#143743)
  Bar searching or sorting on _seq_no when disabled (elastic#143600)
  Generalize `testClientCancellation` test (elastic#143586)
  JSON_EXTRACT: zero-copy byte slicing for object, array, and number extraction (elastic#143702)
  Track recycler pages in circuit breaker (elastic#143738)
  [ESQL] Enable distributed pipeline breakers for external sources via FragmentExec (elastic#143696)
  Adding 'mode' and 'codec' fields to ES monitoring template (elastic#143673)
  [ESQL] Columnar I/O and vectorized block conversion for external sources (elastic#143703)
  Fix flaky MMR diversification YAML tests (elastic#143706)
  ES|QL codegen: check builder arguments for vector support (elastic#143724)
  Add Views Security Model (elastic#141050)
  ESQL: Prevent pushdown of unmapped fields in filters and sorts (elastic#143460)
  Don't run seq_no pruning tests in release CI (elastic#143725)
  ESQL: Support intra-row field references in ROW command (elastic#140217)
  ES|QL: Remove implicit limit in FORK branches in CSV tests (elastic#143601)
  IndexRoutingTests with and without synthetic id (elastic#143566)
  Synthetic id upgrade test in serverless (elastic#142471)
  Disable "Review skipped" comments for PRs without specified labels (elastic#143728)
  Cleanup ES|QL T-Digest code duplication, add memory accounting (elastic#143662)
  ...
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Mar 6, 2026
…tic#143743)

This fixes debug log messages added in elastic#143567 where the endpoint
id is not correctly included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants