[Inference API] Display name and model_creator in endpoint metadata by dimitris-athanasiou · Pull Request #144124 · elastic/elasticsearch

dimitris-athanasiou · 2026-03-12T17:33:34Z

This commit aligns EIS authorization endpoint parsing with the new format that contains:

{
  ...,
  "display": {
    "name": "My Model",
    "model_creator": "My Model Creator"
  }
}

and modifies EndpointMetadata.Display to accommodate the new model_creator field.

This commit aligns EIS authorization endpoint parsing with the new format that contains: ``` { ..., "display": { "name": "My Model", "model_creator": "My Model Creator" } } ``` and modifies `EndpointMetadata.Display` to accommodate the new `model_creator` field.

elasticsearchmachine · 2026-03-12T17:33:59Z

Pinging @elastic/search-inference-team (Team:Search - Inference)

coderabbitai · 2026-03-12T17:42:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b38a1f97-d440-4dd0-b2d3-5f85c75a6be9

📥 Commits

Reviewing files that changed from the base of the PR and between 00b318f and 15151e1.

📒 Files selected for processing (1)

server/src/test/java/org/elasticsearch/inference/MinimalServiceSettingsTests.java

📝 Walkthrough

Walkthrough

This PR adds a nullable modelCreator field to EndpointMetadata.Display, updates its parsing, serialization, transport-version gating, and tests to handle the new field, and introduces Display.EMPTY_INSTANCE. ModelConfigurations now exposes a nullable getEndpointMetadata() plus a non-null-safe getEndpointMetadataOrEmpty(). Call sites are updated to use the appropriate accessor. The endpoint schema version is bumped to 1, and response/authorization types and tests are adjusted to carry EndpointMetadata.Display objects instead of plain display-name strings.

Possibly related PRs

Correctly include endpoint id in log msg in AuthorizationPoller #143743: Modifies AuthorizationPoller.shouldPersistEndpoint — addresses the same method where this PR changed endpoint-metadata access to getEndpointMetadataOrEmpty().
Remove serialization logic from EIS authorization response #144021: Changes ElasticInferenceServiceAuthorizationResponseEntity/AuthorizedEndpoint display handling — overlaps with this PR’s migration from display-name strings to EndpointMetadata.Display.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the high-level summary generated by CodeRabbit.

Configure the reviews.high_level_summary_instructions setting to provide custom instructions for generating the high-level summary.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@server/src/test/java/org/elasticsearch/inference/MinimalServiceSettingsTests.java`:
- Line 66: The expected JSON constant
MINIMAL_SERVICE_SETTINGS_WITH_METADATA_JSON is missing the emitted
display.model_creator field because the test now constructs
EndpointMetadata.Display("name", "creator"); update
MINIMAL_SERVICE_SETTINGS_WITH_METADATA_JSON to include "display": {"name":
"<expected>", "model_creator": "creator"} (or the appropriate ordering/format
used by MinimalServiceSettings.toXContent) so
testToXContentMinimalServiceSettingsWithEndpointMetadata matches the output of
MinimalServiceSettings.toXContent when given EndpointMetadata.Display; locate
the JSON constant and adjust the display object to contain model_creator
alongside name.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8f3f81fc-a9ec-4333-8963-996c78453446

📥 Commits

Reviewing files that changed from the base of the PR and between b44757b and 00b318f.

⛔ Files ignored due to path filters (2)

server/src/main/resources/transport/definitions/referable/inference_endpoint_metadata_display_model_creator_added.csv is excluded by !**/*.csv
server/src/main/resources/transport/upper_bounds/9.4.csv is excluded by !**/*.csv

📒 Files selected for processing (15)

server/src/main/java/org/elasticsearch/inference/MinimalServiceSettings.java
server/src/main/java/org/elasticsearch/inference/ModelConfigurations.java
server/src/main/java/org/elasticsearch/inference/metadata/EndpointMetadata.java
server/src/test/java/org/elasticsearch/inference/EndpointMetadataTests.java
server/src/test/java/org/elasticsearch/inference/MinimalServiceSettingsTests.java
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/parser/EndpointMetadataParser.java
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/authorization/AuthorizationPoller.java
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/authorization/ElasticInferenceServiceAuthorizationModel.java
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/authorization/EndpointSchemaMigration.java
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/response/ElasticInferenceServiceAuthorizationResponseEntity.java
x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/ModelConfigurationsTests.java
x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/parser/EndpointMetadataParserTests.java
x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/authorization/AuthorizationPollerTests.java
x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/authorization/ElasticInferenceServiceAuthorizationModelTests.java
x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/response/ElasticInferenceServiceAuthorizationResponseEntityTests.java

server/src/test/java/org/elasticsearch/inference/MinimalServiceSettingsTests.java

jonathan-buttner

Great work!

jonathan-buttner · 2026-03-12T17:46:51Z

...rg/elasticsearch/xpack/inference/services/elastic/authorization/EndpointSchemaMigration.java

     * response.
     */
-    public static final Long ENDPOINT_SCHEMA_VERSION = 0L;
+    public static final Long ENDPOINT_SCHEMA_VERSION = 1L;


jonathan-buttner · 2026-03-12T17:47:34Z

server/src/test/java/org/elasticsearch/inference/MinimalServiceSettingsTests.java

I think coderabbit is saying this one might need the model_creator field?

Yep! Added a fix: 15151e1

jonathan-buttner · 2026-03-12T17:47:54Z

server/src/main/java/org/elasticsearch/inference/metadata/EndpointMetadata.java

            return builder;
        }

-        @Override


Thank you 🙏

…etadata

…lastic#144124) This commit aligns EIS authorization endpoint parsing with the new format that contains: ``` { ..., "display": { "name": "My Model", "model_creator": "My Model Creator" } } ``` and modifies `EndpointMetadata.Display` to accommodate the new `model_creator` field.

dimitris-athanasiou added >non-issue :SearchOrg/Inference Label for the Search Inference team v9.4.0 labels Mar 12, 2026

dimitris-athanasiou requested a review from jonathan-buttner March 12, 2026 17:33

elasticsearchmachine added the Team:Search - Inference label Mar 12, 2026

coderabbitai bot reviewed Mar 12, 2026

View reviewed changes

server/src/test/java/org/elasticsearch/inference/MinimalServiceSettingsTests.java Show resolved Hide resolved

jonathan-buttner approved these changes Mar 12, 2026

View reviewed changes

dimitris-athanasiou added 2 commits March 12, 2026 20:01

Fix MinimalServiceSettingsTests

15151e1

Merge branch 'main' into display-name-and-model_creator-in-endpoint-m…

217717e

…etadata

dimitris-athanasiou merged commit 0e409a4 into elastic:main Mar 13, 2026
36 checks passed

dimitris-athanasiou deleted the display-name-and-model_creator-in-endpoint-metadata branch March 13, 2026 13:03

coderabbitai bot mentioned this pull request Mar 17, 2026

[Inference API] Adding OAuth2 support for Azure OpenAI #143896

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Inference API] Display name and model_creator in endpoint metadata#144124

[Inference API] Display name and model_creator in endpoint metadata#144124
dimitris-athanasiou merged 3 commits intoelastic:mainfrom
dimitris-athanasiou:display-name-and-model_creator-in-endpoint-metadata

dimitris-athanasiou commented Mar 12, 2026

Uh oh!

elasticsearchmachine commented Mar 12, 2026

Uh oh!

coderabbitai bot commented Mar 12, 2026 •

edited

Loading

Walkthrough

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

jonathan-buttner left a comment

Uh oh!

jonathan-buttner Mar 12, 2026

Uh oh!

jonathan-buttner Mar 12, 2026

Uh oh!

dimitris-athanasiou Mar 12, 2026

Uh oh!

jonathan-buttner Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dimitris-athanasiou commented Mar 12, 2026

Uh oh!

elasticsearchmachine commented Mar 12, 2026

Uh oh!

coderabbitai bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonathan-buttner left a comment

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

dimitris-athanasiou Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 12, 2026 •

edited

Loading