Bar searching or sorting on _seq_no when disabled#143600
Bar searching or sorting on _seq_no when disabled#143600elasticsearchmachine merged 15 commits intoelastic:mainfrom
Conversation
If sequence numbers are trimmed from an index, then it should not be possible to search or sort against the metadata field.
romseygeek
added
>non-issue
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
fcofdez
left a comment
fcofdez
left a comment
There was a problem hiding this comment.
LGTM. But maybe it makes sense to have someone from storage engine reviewing this too?
| static final class SeqNoFieldType extends SimpleMappedFieldType { | ||
| private static final SeqNoFieldType WITH_POINT = new SeqNoFieldType(true); | ||
| private static final SeqNoFieldType NO_POINT = new SeqNoFieldType(false); | ||
| private static final MappedFieldType UNSEARCHABLE = new UnsearchableFieldType(NAME, CONTENT_TYPE, Map.of()); |
There was a problem hiding this comment.
Could we somehow mention that the field is not searchable due to sequence numbers being trimmed with DISABLE_SEQUENCE_NUMBERS enabled?
I think that might help troubleshooting why queries fail.
…' into seqno/disallow-seqno-queries
| body: | ||
| query: | ||
| term: | ||
| _seq_no: 0 |
There was a problem hiding this comment.
Consider adding checks for the error, like
- match: { error.type: "illegal_argument_exception" }
- match: { error.reason: "Iterable object is self-referencing itself" }
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…' into seqno/disallow-seqno-queries
In the stateless architecture, search nodes need search replicas to serve queries. Setting replicas to 0 prevents search shard allocation on search nodes. Made-with: Cursor
…' into seqno/disallow-seqno-queries
…locations * upstream/main: (153 commits) ES|QL: Update docs for TOP_SNIPPETS and DECAY (elastic#143739) Correctly include endpoint id in log msg in AuthorizationPoller (elastic#143743) Bar searching or sorting on _seq_no when disabled (elastic#143600) Generalize `testClientCancellation` test (elastic#143586) JSON_EXTRACT: zero-copy byte slicing for object, array, and number extraction (elastic#143702) Track recycler pages in circuit breaker (elastic#143738) [ESQL] Enable distributed pipeline breakers for external sources via FragmentExec (elastic#143696) Adding 'mode' and 'codec' fields to ES monitoring template (elastic#143673) [ESQL] Columnar I/O and vectorized block conversion for external sources (elastic#143703) Fix flaky MMR diversification YAML tests (elastic#143706) ES|QL codegen: check builder arguments for vector support (elastic#143724) Add Views Security Model (elastic#141050) ESQL: Prevent pushdown of unmapped fields in filters and sorts (elastic#143460) Don't run seq_no pruning tests in release CI (elastic#143725) ESQL: Support intra-row field references in ROW command (elastic#140217) ES|QL: Remove implicit limit in FORK branches in CSV tests (elastic#143601) IndexRoutingTests with and without synthetic id (elastic#143566) Synthetic id upgrade test in serverless (elastic#142471) Disable "Review skipped" comments for PRs without specified labels (elastic#143728) Cleanup ES|QL T-Digest code duplication, add memory accounting (elastic#143662) ...
If sequence numbers are trimmed from an index, then it should not be possible to search or sort against the metadata field. Related to elastic#136305
5 participants
If sequence numbers are trimmed from an index, then it should not be
possible to search or sort against the metadata field.
Related to #136305