Run 25_id_generation with and without synthetic id#142770
Merged
burqen merged 4 commits intoelastic:mainfrom Feb 24, 2026
Merged
Run 25_id_generation with and without synthetic id#142770burqen merged 4 commits intoelastic:mainfrom
burqen merged 4 commits intoelastic:mainfrom
Conversation
Add 25_id_generation_synthetic_id.yml as copy of 25_id_generation.yml but with index.mapping.synthetic_id=true and updated expected id value. Add synthetic id feature flag to ClientYamlTestSuiteIT Harden 25_id_generation.yml to use synthetic_id=false
burqen
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
burqen
commented
Feb 20, 2026
Contributor
Author
There was a problem hiding this comment.
I have no idea if the number in the file name has any significance. Will look into it.
Contributor
Author
There was a problem hiding this comment.
The number is significant because it affect the order of the tests. They are ordered before being shuffled for predictability. Will rename this to 26_ instead.
https://github.com/elastic/elasticsearch/blob/main/test/yaml-rest-runner/src/main/java/org/elasticsearch/test/rest/yaml/ESClientYamlSuiteTestCase.java#L337
16 tasks
Because tsdb/25_id_generation also runs in mixed and backwards compatible cluster we cannot use synthetic_id setting at all unless the cluster has cluster_features: "index.time_series_synthetic_id". Introduce tsdb/26_id_generation_synthetic_id_false that specifically set the setting to false and otherwise keep the behaviour from 25_generation_id. 26_id_generation_synthetic_id.yml is renamed to 27_id_generation_synthetic_id_true.yml TL;DR: Version <9.4 run 25_id_generation.yml Version >=9.4 run 26_id_generation_synthetic_id_synthetic_false.yml and 27_id_generation_synthetic_id_true.yml
…etic-id-yml-hard-coded-ids
sidosera
pushed a commit
to sidosera/elasticsearch
that referenced
this pull request
Feb 24, 2026
* Run 25_id_generation with and without synthetic id Add 25_id_generation_synthetic_id.yml as copy of 25_id_generation.yml but with index.mapping.synthetic_id=true and updated expected id value. Add synthetic id feature flag to ClientYamlTestSuiteIT Harden 25_id_generation.yml to use synthetic_id=false * Rename 25_id_generation_synthetic_id -> 26_id_... * yaml tsdb/25_id_generation backwards compatible Because tsdb/25_id_generation also runs in mixed and backwards compatible cluster we cannot use synthetic_id setting at all unless the cluster has cluster_features: "index.time_series_synthetic_id". Introduce tsdb/26_id_generation_synthetic_id_false that specifically set the setting to false and otherwise keep the behaviour from 25_generation_id. 26_id_generation_synthetic_id.yml is renamed to 27_id_generation_synthetic_id_true.yml TL;DR: Version <9.4 run 25_id_generation.yml Version >=9.4 run 26_id_generation_synthetic_id_synthetic_false.yml and 27_id_generation_synthetic_id_true.yml
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Feb 24, 2026
…on-sliced-reindex * upstream/main: Activity logging improvements (elastic#142901) Fix serialization of NodeGpuStatsResponse when no GPU is present (elastic#142937) Add doc on master elections in DistributedArchitectureGuide (elastic#142435) ESQL: Account for missing StubRelation due to SurrogateExpressions replacement (elastic#142882) Add BulkByScrollTask Serialization Tests (elastic#142697) Rebalance CI test partitions to reduce Part3 bottleneck (elastic#142930) Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlClientYamlIT test {p0=esql/40_tsdb/to_aggregate_metric_double with multi_values} elastic#142964 Bump OpenTelemetry dependencies (elastic#142323) SQL: add support for API key to JDBC and CLI (elastic#142021) Ensure requested capability exists (elastic#142695) Warn and fall back to local branches.json (elastic#142606) [CI] Mute testWithFetchFailures, testAddCompletionListenerScheduleErr… (elastic#142926) ESQL: Add support for ORC file format (elastic#142900) Update wolfi (versioned) (elastic#142948) Add BulkByScrollResponse Serialization Tests (elastic#142688) Run 25_id_generation with and without synthetic id (elastic#142770)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intention is to
tsdb/25_id_generation.ymlnot fail when enablingindex.mapping.synthetic_idby defaulttsdb/25_id_generation.ymlboth with and withoutindex.mapping.synthetic_idtsdb/25_id_generation.ymlhas a lot of hard coded ids. When enablingindex.mapping.synthetic_id, the id generation changes and those hard coded ids are no longer valid. We completely skip25_id_generationif cluster has synthetic id feature.If the cluster has synthetic id feature we run both and
26_id_generation_synthetic_id_falseand27_id_generation_synthetic_id_true. Both of which are copies of25_id_generationbut withsynthetic_idexplicitly set to false/true. In27_id_generation_synthetic_id_true, the ids are updated to fit the new synthetic ids.Add the feature flag to
ClientYamlTestSuiteIT.