Skip to content

Split delete/70_tsdb.yml for synthetic_id TRUE/FALSE#142932

Merged
burqen merged 3 commits intoelastic:mainfrom
burqen:ap/2026.02.24.synthetic-id-fix-yml-delete-70
Feb 26, 2026
Merged

Split delete/70_tsdb.yml for synthetic_id TRUE/FALSE#142932
burqen merged 3 commits intoelastic:mainfrom
burqen:ap/2026.02.24.synthetic-id-fix-yml-delete-70

Conversation

@burqen
Copy link
Copy Markdown
Contributor

@burqen burqen commented Feb 24, 2026

Same intention and procedure as #142770

Intention is to

  • make delete/70_tsdb.yml not fail when enabling index.mapping.synthetic_id by default
  • run the tests from delete/70_tsdb.yml both with and without index.mapping.synthetic_id

delete/70_tsdb.yml has hard coded ids. When enabling index.mapping.synthetic_id, the id generation changes and those hard coded ids are no longer valid. We completely skip 70_tsdb if cluster has synthetic id feature.

If the cluster has synthetic id feature we run both and 71_tsdb_synthetic_id_false and 72_tsdb_synthetic_id_true. Both of which are copies of 70_tsdb but with synthetic_id explicitly set to false/true. In 72_tsdb_synthetic_id_true, the ids are updated to fit the new synthetic ids.

@burqen burqen added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics v9.4.0 labels Feb 24, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@burqen burqen requested a review from tlrx February 24, 2026 10:16
- Original 70_tsdb: skip when cluster has synthetic_id feature
- 71_tsdb_synthetic_id_false: explicit synthetic_id false
- 72_tsdb_synthetic_id_true: explicit synthetic_id true, synthetic _id

Co-authored-by: Cursor <cursoragent@cursor.com>
@burqen burqen force-pushed the ap/2026.02.24.synthetic-id-fix-yml-delete-70 branch from 75b379f to e389a8d Compare February 24, 2026 16:11
Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burqen burqen merged commit 25c2796 into elastic:main Feb 26, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants