Skip to content

Add BulkByScrollTask Serialization Tests#142697

Merged
joshua-adams-1 merged 10 commits intoelastic:mainfrom
joshua-adams-1:spacetime-bulk-by-scroll-task
Feb 24, 2026
Merged

Add BulkByScrollTask Serialization Tests#142697
joshua-adams-1 merged 10 commits intoelastic:mainfrom
joshua-adams-1:spacetime-bulk-by-scroll-task

Conversation

@joshua-adams-1
Copy link
Copy Markdown
Contributor

Extends the BulkByScrollTask test coverage by adding extra unit tests to BulkByScrollTaskTests, BulkByScrollTaskStatusOrExceptionTests and BulkByScrollTaskStatusTests. It also adds serialization tests in BulkByScrollTaskStatusOrExceptionWireSerializingTests and BulkByScrollTaskStatusWireSerializingTests

@joshua-adams-1 joshua-adams-1 self-assigned this Feb 19, 2026
@joshua-adams-1 joshua-adams-1 added >test Issues or PRs that are addressing/adding tests :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. labels Feb 19, 2026
private boolean includeUpdated;
private boolean includeCreated;

public void testBulkByTaskStatus() throws IOException {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BulkByScrollTaskStatusWireSerializingTests adds greater test coverage than this previously provided

@joshua-adams-1 joshua-adams-1 marked this pull request as ready for review February 23, 2026 11:00
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Feb 23, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@joshua-adams-1 joshua-adams-1 requested review from samxbr and removed request for PeteGillinElastic, samxbr and szybia February 23, 2026 11:55
Copy link
Copy Markdown
Contributor

@samxbr samxbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-adams-1 joshua-adams-1 merged commit df16cba into elastic:main Feb 24, 2026
35 checks passed
@joshua-adams-1 joshua-adams-1 deleted the spacetime-bulk-by-scroll-task branch February 24, 2026 16:14
szybia added a commit to szybia/elasticsearch that referenced this pull request Feb 24, 2026
…on-sliced-reindex

* upstream/main:
  Activity logging improvements (elastic#142901)
  Fix serialization of NodeGpuStatsResponse when no GPU is present (elastic#142937)
  Add doc on master elections in DistributedArchitectureGuide (elastic#142435)
  ESQL: Account for missing StubRelation due to SurrogateExpressions replacement (elastic#142882)
  Add BulkByScrollTask Serialization Tests (elastic#142697)
  Rebalance CI test partitions to reduce Part3 bottleneck (elastic#142930)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlClientYamlIT test {p0=esql/40_tsdb/to_aggregate_metric_double with multi_values} elastic#142964
  Bump OpenTelemetry dependencies (elastic#142323)
  SQL: add support for API key to JDBC and CLI (elastic#142021)
  Ensure requested capability exists (elastic#142695)
  Warn and fall back to local branches.json (elastic#142606)
  [CI] Mute testWithFetchFailures, testAddCompletionListenerScheduleErr… (elastic#142926)
  ESQL: Add support for ORC file format (elastic#142900)
  Update wolfi (versioned) (elastic#142948)
  Add BulkByScrollResponse Serialization Tests (elastic#142688)
  Run 25_id_generation with and without synthetic id (elastic#142770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants