Conversation
Removes unused methods from TransportVersionUtils and TransformConfigVersionUtils
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Going to ask core/infra whether there's any reason to keep these (e.g. some test suite external to this repo that uses them?) |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
I don't really have any input on MlConfigVersionUtils or TransformConfigVersionUtils. I'll leave that to the ML folks, but changes to TransportVersionUtils LGTM.
| } | ||
|
|
||
| /** Returns the oldest known {@link TransportVersion} */ | ||
| public static TransportVersion getFirstVersion() { |
There was a problem hiding this comment.
I agree this should go. @jdconrad and I already discussed this. In every case what people want is TransportVersion.minimumCompatible().
For future reference then, what repos use code inside ElasticSearch that I should be aware of? Ie if I see another unused method I'd like to check everywhere first before removing and this would save me making a mistake |
It would only be serverless and we test that as part of pull requests so if CI passes here it should be safe to remove. |
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Ok let's go for it then LGTM
* upstream/main: (76 commits) [Inference API] Get _services skips EIS authorization call if CCM is not configured (elastic#139964) Improve TSDB codec benchmarks with full encoder and compression metrics (elastic#140299) ESQL: Consolidate test `BlockLoaderContext`s (elastic#140403) ESQL: Improve Lookup Join performance with CachedDirectoryReader (elastic#139314) ES|QL: Add more examples for the match operator (elastic#139815) ESQL: Add timezone to add and sub operators, and ConfigurationAware planning support (elastic#140101) ESQL: Updated ToIp tests and generated documentation for map parameters (elastic#139994) Disable _delete_by_query and _update_by_query for CCS/stateful (elastic#140301) Remove unused method ElasticInferenceService.translateToChunkedResults (elastic#140442) logging hot threads on large queue of the management threadpool (elastic#140251) Search functions docs cleanup (elastic#140435) Unmute 350_point_in_time/point-in-time with index filter (elastic#140443) Remove unused methods (elastic#140222) Add CPS and `project_routing` support for `_mvt` (elastic#140053) Streamline `ShardDeleteResults` collection (elastic#140363) Fix Docker build to use --load for single-platform images (elastic#140402) Parametrize + test VectorScorerOSQBenchmark (elastic#140354) `RecyclerBytesStreamOutput` using absolute offsets (elastic#140303) Define bulk float native methods for vector scoring (elastic#139885) Make `TimeSeriesAggregate` `TimestampAware` (elastic#140270) ...
Removes unused methods from TransportVersionUtils and TransformConfigVersionUtils
repantis
added
:Distributed/Distributed
5 participants
Removes unused methods from
TransportVersionUtilsandTransformConfigVersionUtils