Skip to content

Streamline ShardDeleteResults collection#140363

Merged
DaveCTurner merged 5 commits intoelastic:mainfrom
DaveCTurner:2026/01/08/ShardBlobsToDelete-BufferedStreamOutput
Jan 9, 2026
Merged

Streamline ShardDeleteResults collection#140363
DaveCTurner merged 5 commits intoelastic:mainfrom
DaveCTurner:2026/01/08/ShardBlobsToDelete-BufferedStreamOutput

Conversation

@DaveCTurner
Copy link
Contributor

We expect this to be pretty large sometimes, its lifespan is limited,
and there won't be very many of them active at once, so we may as well
allocate entire pages with a RecyclerBytesStreamOutput instead of
using the frequent resizing of the BigArrays underneath the
ReleasableBytesStreamOutput.

Also migrates to using the new BufferedStreamOutput instead of the
relatively inefficient OutputStreamStreamOutput adapter.

We expect this to be pretty large sometimes, its lifespan is limited,
and there won't be very many of them active at once, so we may as well
allocate entire pages with a `RecyclerBytesStreamOutput` instead of
using the frequent resizing of the `BigArrays` underneath the
`ReleasableBytesStreamOutput`.

Also migrates to using the new `BufferedStreamOutput` instead of the
relatively inefficient `OutputStreamStreamOutput` adapter.
@DaveCTurner DaveCTurner added >non-issue :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v9.4.0 labels Jan 8, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. label Jan 8, 2026
Copy link
Contributor

@joshua-adams-1 joshua-adams-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaveCTurner DaveCTurner enabled auto-merge (squash) January 8, 2026 14:49
@DaveCTurner DaveCTurner merged commit 2021f59 into elastic:main Jan 9, 2026
35 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 9, 2026
* upstream/main: (76 commits)
  [Inference API] Get _services skips EIS authorization call if CCM is not configured (elastic#139964)
  Improve TSDB codec benchmarks with full encoder and compression metrics (elastic#140299)
  ESQL: Consolidate test `BlockLoaderContext`s (elastic#140403)
  ESQL: Improve Lookup Join performance with CachedDirectoryReader (elastic#139314)
  ES|QL: Add more examples for the match operator (elastic#139815)
  ESQL: Add timezone to add and sub operators, and ConfigurationAware planning support (elastic#140101)
  ESQL: Updated ToIp tests and generated documentation for map parameters (elastic#139994)
  Disable _delete_by_query and _update_by_query for CCS/stateful (elastic#140301)
  Remove unused method ElasticInferenceService.translateToChunkedResults (elastic#140442)
  logging hot threads on large queue of the management threadpool (elastic#140251)
  Search functions docs cleanup (elastic#140435)
  Unmute 350_point_in_time/point-in-time with index filter (elastic#140443)
  Remove unused methods (elastic#140222)
  Add CPS and `project_routing` support for `_mvt` (elastic#140053)
  Streamline `ShardDeleteResults` collection (elastic#140363)
  Fix Docker build to use --load for single-platform images (elastic#140402)
  Parametrize + test VectorScorerOSQBenchmark (elastic#140354)
  `RecyclerBytesStreamOutput` using absolute offsets (elastic#140303)
  Define bulk float native methods for vector scoring (elastic#139885)
  Make `TimeSeriesAggregate` `TimestampAware` (elastic#140270)
  ...
jimczi pushed a commit to jimczi/elasticsearch that referenced this pull request Jan 12, 2026
We expect this to be pretty large sometimes, its lifespan is limited,
and there won't be very many of them active at once, so we may as well
allocate entire pages with a `RecyclerBytesStreamOutput` instead of
using the frequent resizing of the `BigArrays` underneath the
`ReleasableBytesStreamOutput`.

Also migrates to using the new `BufferedStreamOutput` instead of the
relatively inefficient `OutputStreamStreamOutput` adapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants