Removes random parameter

[joshua-adams-1]

A number of utils methods in TransportVersionUtils, MlConfigVersionUtils, VersionUtils, IndexVersionUtils and TransformConfigVersionUtils had a random parameter that was only ever passed in as Lucene.test.random(). This removes the unnecessary parameter.

[elasticsearchmachine]

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

[DaveCTurner]

Ok with the ones that remove the random() argument from method calls, just a little supicious about the ones that remove actual methods. Let's see what core/infra say about #140222 - maybe there's some good reason why we were passing a Random around everywhere here?

[joshua-adams-1]

I was only removing the method because it was overloading a parameterless one, and so me removing the parameter made a duplicate method. E.g:

/** Returns a random {@link TransportVersion} from all available versions. */
    public static TransportVersion randomVersion() {
        return RandomPicks.randomFrom(random(), allReleasedVersions());
    }
    /** Returns a random {@link TransportVersion} from all available versions without the ignore set */
    public static TransportVersion randomVersion(Set<TransportVersion> ignore) {
        return ESTestCase.randomFrom(allReleasedVersions().stream().filter(v -> ignore.contains(v) == false).collect(Collectors.toList()));
    }

    /** Returns a random {@link TransportVersion} from all available versions. */
    public static TransportVersion randomVersion(Random random) {
        return RandomPicks.randomFrom(random, allReleasedVersions());
    }

by removing Random random as a parameter becomes:

/** Returns a random {@link TransportVersion} from all available versions. */
    public static TransportVersion randomVersion() {
        return RandomPicks.randomFrom(random(), allReleasedVersions());
    }
    /** Returns a random {@link TransportVersion} from all available versions without the ignore set */
    public static TransportVersion randomVersion(Set<TransportVersion> ignore) {
        return ESTestCase.randomFrom(allReleasedVersions().stream().filter(v -> ignore.contains(v) == false).collect(Collectors.toList()));
    }

    /** Returns a random {@link TransportVersion} from all available versions. */
    public static TransportVersion randomVersion() {
        return RandomPicks.randomFrom(random(), allReleasedVersions());
    }

which has a duplicate of the existing, hence the whole method got removed

[joshua-adams-1]

To clarify, I did not remove any method that according to IntelliJ "wasn't used anywhere". That was reserved for #140222 so it could be a separate discussion

[joshua-adams-1]

As a note, #140222 has been merged

[DaveCTurner]

Ok LGTM