Add disable_templating index setting/mapping parameter to patterned_text#134466
Merged
jordan-powers merged 24 commits intoelastic:mainfrom Sep 16, 2025
Merged
Add disable_templating index setting/mapping parameter to patterned_text#134466jordan-powers merged 24 commits intoelastic:mainfrom
jordan-powers merged 24 commits intoelastic:mainfrom
Conversation
jordan-powers
changed the title
martijnvg
reviewed
Sep 11, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
This looks in the right direction. I left a few comments.
...gin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProvider.java
Show resolved
Hide resolved
| "index.mapping.patterned_text_disable_enterprise", | ||
| false, | ||
| Setting.Property.IndexScope, | ||
| Setting.Property.InternalIndex |
Member
There was a problem hiding this comment.
Should this be PrivateIndex? I think right now this isn't possible ,however #133789 just got merged, that should allow this.
| * no valid enterprise license. | ||
| */ | ||
| public static final Setting<Boolean> PATTERNED_TEXT_BASIC_SETTING = Setting.boolSetting( | ||
| "index.mapping.patterned_text_disable_enterprise", |
Member
There was a problem hiding this comment.
Maybe rename this to index.mapping.patterned_text.disable_templating? So this looks less license oriented and more of a flag to disable a functionality.
Contributor
Author
There was a problem hiding this comment.
Agreed, I wasn't happy with that name, I just couldn't think of anything better at the moment. patterned_text.disable_templating sounds good to me
jordan-powers
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Contributor
Author
|
Failing release tests are known issues being addressed in other PRs: |
martijnvg
approved these changes
Sep 16, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM, thanks @jordan-powers!
Contributor
Author
|
The only failing test is an unrelated known issue (#134640), so I'll merge anyway. |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
…ext (elastic#134466) This patch is the first step to gate the storage savings of the patterned_text field mapper behind an enterprise license. A new index setting ``index.mapping.patterned_text.disable_templating` is set on index creation if the current license does not support the patterned text enterprise-level storage savings. This index setting is then used to set the parameter disable_templating on the patterned text mapper.
jordan-powers
added a commit
that referenced
this pull request
Sep 17, 2025
Follow-up to #134466 to actually check the disable_templating parameter in the patterned_text mapper. When the parameter is set, values will be stored as-is in a stored field.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
…ext (elastic#134466) This patch is the first step to gate the storage savings of the patterned_text field mapper behind an enterprise license. A new index setting ``index.mapping.patterned_text.disable_templating` is set on index creation if the current license does not support the patterned text enterprise-level storage savings. This index setting is then used to set the parameter disable_templating on the patterned text mapper.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
Follow-up to elastic#134466 to actually check the disable_templating parameter in the patterned_text mapper. When the parameter is set, values will be stored as-is in a stored field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step to gate the storage savings of the patterned_text field mapper behind an enterprise license.
A new index setting
index.mapping.patterned_text.disable_templatingis set on index creation if the current license does not support the patterned text enterprise-level storage savings.This index setting is then used to set the parameter
disable_templatingon the patterned text mapper.