Patterned text conditionally disable templating#134744
Merged
jordan-powers merged 4 commits intoelastic:mainfrom Sep 17, 2025
Merged
Patterned text conditionally disable templating#134744jordan-powers merged 4 commits intoelastic:mainfrom
jordan-powers merged 4 commits intoelastic:mainfrom
Conversation
jordan-powers
added
>non-issue
:StorageEngine/Logs
jordan-powers
force-pushed
the
patterned-text-conditionally-disable-templating
branch
from
2ba4ae4 to
daec41c
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| try (var searcher = indexService.getShard(0).acquireSearcher(INDEX)) { | ||
| try (var indexReader = searcher.getIndexReader()) { | ||
| var document = indexReader.storedFields().document(0); | ||
| assertNull(document.getField("field_patterned_text.stored")); |
Contributor
There was a problem hiding this comment.
Nit: ^ maybe update the above comment to "assert only contains stored field if templating is disabled"
parkertimmins
approved these changes
Sep 16, 2025
Contributor
parkertimmins
left a comment
parkertimmins
left a comment
There was a problem hiding this comment.
Looks correct to me. I like the parameter factory testing stuff 👍
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
Follow-up to elastic#134466 to actually check the disable_templating parameter in the patterned_text mapper. When the parameter is set, values will be stored as-is in a stored field.
jordan-powers
deleted the
patterned-text-conditionally-disable-templating
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #134466 to actually check the
disable_templatingparameter in the patterned_text mapper. When the parameter is set, values will be stored as-is in a stored field.