Increment ESQL expected function count#134745
Merged
jordan-powers merged 1 commit intoelastic:mainfrom Sep 15, 2025
Merged
Conversation
jordan-powers
added
test-release
jordan-powers
changed the title
jordan-powers
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
approved these changes
Sep 15, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. We are discussing to nuke this test. Thanks Jordan!
Contributor
Author
|
The one failing release test is a known issue and will be resolved in #134734. The serverless checks are also failing, I'll try rerunning them. |
Contributor
Author
|
The serverless checks also failed on rerun. However the failing tests are all generative CSV ESQL tests, which is unrelated to my change. |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
In elastic#134475 we added another ES|QL function, but forgot to increment the expected function count in the "60_usage/Basic ESQL usage output (telemetry) non-snapshot version" test, causing release tests to fail. This PR fixes that.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
In elastic#134475 we added another ES|QL function, but forgot to increment the expected function count in the "60_usage/Basic ESQL usage output (telemetry) non-snapshot version" test, causing release tests to fail. This PR fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #134475 we added another ES|QL function, but forgot to increment the expected function count in the "60_usage/Basic ESQL usage output (telemetry) non-snapshot version" test, causing release tests to fail. This PR fixes that.