Skip to content

chore(opentelemetry-node)!: drop instrumentation-fastify#1395

Merged
trentm merged 3 commits into
mainfrom
trentm-drop-instr-fastify
Mar 26, 2026
Merged

chore(opentelemetry-node)!: drop instrumentation-fastify#1395
trentm merged 3 commits into
mainfrom
trentm-drop-instr-fastify

Conversation

@trentm
Copy link
Copy Markdown
Member

@trentm trentm commented Mar 26, 2026

Upstream has dropped instrumentation-fastify, so we are as well.
The test case has changed to verify that using EDOT Node.js and
the 3rd-party @fastify/otel works.

Refs: open-telemetry/opentelemetry-js-contrib#3409

Upstream has dropped instrumentation-fastify, so we are as well.
The test case has changed to verify that using EDOT Node.js and
the 3rd-party @fastify/otel works.

Refs: open-telemetry/opentelemetry-js-contrib#3409
@trentm trentm self-assigned this Mar 26, 2026
@trentm trentm requested review from a team as code owners March 26, 2026 18:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc0454f2-5afc-4a8a-8ac4-803a9a8f8286

📥 Commits

Reviewing files that changed from the base of the PR and between 452e12b and a40a665.

📒 Files selected for processing (2)
  • packages/opentelemetry-node/lib/instrumentations.js
  • packages/opentelemetry-node/test/fixtures/telemetry-with-fastify-otel.mjs
✅ Files skipped from review due to trivial changes (1)
  • packages/opentelemetry-node/test/fixtures/telemetry-with-fastify-otel.mjs
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/opentelemetry-node/lib/instrumentations.js

📝 Walkthrough

Walkthrough

This pull request removes built-in Fastify instrumentation from EDOT Node.js by deleting @opentelemetry/instrumentation-fastify from code, types, and dependencies. Documentation and release notes were updated to document the breaking change and migration to the third-party @fastify/otel package, including a new bootstrap fixture (telemetry-with-fastify-otel.mjs). Tests and test fixtures were adjusted to reflect the external instrumentation and updated environment-variable handling. Package scripts and lint checks were updated to account for the new/removed packages.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch trentm-drop-instr-fastify
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@trentm trentm merged commit 3c2055c into main Mar 26, 2026
16 checks passed
@trentm trentm deleted the trentm-drop-instr-fastify branch March 26, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants