Skip to content

feat(auto-instrumentations-node, instrumentation-fastify)!: remove instrumentation-fastify#3409

Merged
trentm merged 5 commits into
open-telemetry:mainfrom
trentm:trentm-rm-instr-fastify
Mar 4, 2026
Merged

feat(auto-instrumentations-node, instrumentation-fastify)!: remove instrumentation-fastify#3409
trentm merged 5 commits into
open-telemetry:mainfrom
trentm:trentm-rm-instr-fastify

Conversation

@trentm
Copy link
Copy Markdown
Contributor

@trentm trentm commented Mar 2, 2026 •
edited
Loading

In favor of "@fastify/otel". instr-fastify had been deprecated back
in Jan 2025 and planned for removal in Jun 2025.

Refs: #2651
Refs: #2647

@trentm
feat(auto-instrumentations-node, instrumentation-fastify)!: remove in…
3df8111 
…strumentation-fastify

In favor of "@fastify/otel". instr-fastify had been deprecated back
in Jan 2025 and planned for removal in Jun 2025.

Refs: open-telemetry#2651
@trentm trentm self-assigned this Mar 2, 2026
@trentm trentm requested a review from a team as a code owner March 2, 2026 21:17
@github-actions github-actions Bot added pkg:auto-instrumentations-node pkg:instrumentation-fastify pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Mar 2, 2026
@trentm trentm requested a review from a team as a code owner March 2, 2026 21:20
@trentm trentm mentioned this pull request Mar 2, 2026
Closed
1 task
raphael-theriault-swi
raphael-theriault-swi reviewed Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think component_owners.yaml and GUIDELINES.md may still have some mentions of the instrumentation but otherwise LGTM

@trentm
Copy link
Copy Markdown
Contributor Author

trentm commented Mar 2, 2026

I think component_owners.yaml and GUIDELINES.md may still have some mentions

Thanks. I think I got those in my second commit.

@trentm
Copy link
Copy Markdown
Contributor Author

trentm commented Mar 2, 2026

I think I got those in my second commit.

Nope. @raphael-theriault-swi was right, I missed some. Removed those refs in commit 477ed20

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@trentm trentm added has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions and removed pkg-status:unmaintained:autoclose-scheduled labels Mar 3, 2026
@trentm trentm mentioned this pull request Mar 3, 2026
Closed
2 tasks
@trentm
Copy link
Copy Markdown
Contributor Author

trentm commented Mar 3, 2026

When this is merged/released there are a couple other issues that could likely be closed: https://github.com/open-telemetry/opentelemetry-js-contrib/issues?q=state%3Aopen%20label%3Apkg%3Ainstrumentation-fastify

@trentm trentm merged commit ac26e9a into open-telemetry:main Mar 4, 2026
22 checks passed
@otelbot-js-contrib otelbot-js-contrib Bot mentioned this pull request Mar 4, 2026
Merged
vitorvasc added a commit to open-telemetry/opentelemetry.io that referenced this pull request Mar 25, 2026
@vitorvasc
chore(registry): remove deprecated instrumentation-fastify (open-tele…
fb7d23a 
…metry/opentelemetry-js-contrib#3409)

Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
trentm added a commit to elastic/elastic-otel-node that referenced this pull request Mar 26, 2026
@trentm
chore(opentelemetry-node)!: drop instrumentation-fastify
d0cade5 
Upstream has dropped instrumentation-fastify, so we are as well.
The test case has changed to verify that using EDOT Node.js and
the 3rd-party @fastify/otel works.

Refs: open-telemetry/opentelemetry-js-contrib#3409
@trentm trentm mentioned this pull request Mar 26, 2026
Merged
trentm added a commit to elastic/elastic-otel-node that referenced this pull request Mar 26, 2026
@trentm
chore(opentelemetry-node)!: drop instrumentation-fastify (#1395)
3c2055c 
Upstream has dropped instrumentation-fastify, so we are as well.
The test case has changed to verify that using EDOT Node.js and
the 3rd-party @fastify/otel works.

Refs: open-telemetry/opentelemetry-js-contrib#3409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-luna david-luna david-luna approved these changes

@raphael-theriault-swi raphael-theriault-swi raphael-theriault-swi approved these changes

@blumamir blumamir Awaiting requested review from blumamir

@dyladan dyladan Awaiting requested review from dyladan

@legendecas legendecas Awaiting requested review from legendecas

@pichlermarc pichlermarc Awaiting requested review from pichlermarc

Assignees

@trentm trentm

@dyladan dyladan

@legendecas legendecas

@pichlermarc pichlermarc

@blumamir blumamir

Labels

has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:auto-instrumentations-node pkg:instrumentation-fastify pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@trentm @david-luna @raphael-theriault-swi @dyladan @legendecas @pichlermarc @blumamir