Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/release-notes/breaking-changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ Breaking changes can impact your Elastic applications, potentially disrupting no
% 4. You can then call the link from any Kibana code. For example: `href: docLinks.links.upgradeAssistant.id`
% Check https://docs.elastic.dev/docs/kibana-doc-links (internal) for more details about the Doc links service.

## version.next [edot-node-X.X.X-breaking-changes]

::::{dropdown} `OTEL_NODE_ENABLED_INSTRUMENTATIONS=fastify,...` will no longer enable Fastify instrumentation

OpenTelemetry JS has stopped maintaining `@opentelemetry/instrumentation-fastify`, in favor of the separate `@fastify/otel` instrumentation maintained by the Fastify authors. As a result, `@opentelemetry/instrumentation-fastify` has been removed from EDOT Node.js. There is no change in *default* behavior, because the instrumentation had previously been deprecated and required opting-in to enable it.

If you are using the `OTEL_NODE_ENABLED_INSTRUMENTATIONS=fastify,...` environment variable to enable Fastify instrumentation, this will no longer work. You must manually use the [`@fastify/otel` package](https://github.com/fastify/otel#readme). This [bootstrap script](https://github.com/elastic/elastic-otel-node/blob/main/packages/opentelemetry-node/test/fixtures/telemetry-with-fastify-otel.mjs) shows how EDOT Node.js and `@fastify/otel` can be used together to achieve the similar behavior.
::::

## 1.2.0 [edot-node-1.2.0-breaking-changes]

::::{dropdown} Change usage of "redis-4" to "redis" in `OTEL_NODE_ENABLED_INSTRUMENTATIONS` and `OTEL_NODE_DISABLED_INSTRUMENTATIONS`
Expand Down
4 changes: 3 additions & 1 deletion docs/release-notes/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ To check for security updates, go to [Security announcements for the Elastic sta
- [`v2.6.1` release](https://github.com/open-telemetry/opentelemetry-js/releases/tag/v2.6.1) from opentelemetry-js
- [`experimental/v0.214.0` release](https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.214.0) from opentelemetry-js
- [opentelemetry-js-contrib release](https://github.com/open-telemetry/opentelemetry-js-contrib/pull/3415)
- Notably, [`@opentelemetry/instrumentation-fastify` has been removed](https://github.com/open-telemetry/opentelemetry-js-contrib/pull/3409).
- Notably, [`@opentelemetry/instrumentation-fastify` is no longer being updated](https://github.com/open-telemetry/opentelemetry-js-contrib/pull/3409), in favor of `@fastify/otel`.

* Because `@opentelemetry/instrumentation-fastify` is no longer being maintained, it has been removed from EDOT Node.js. This matches the removal from `@opentelemetry/auto-instrumentations-node`. See the [breaking changes note for this release](./breaking-changes.md) for details on how to switch to `@fastify/otel` instrumentation.


## 1.9.0 [edot-node-1.9.0-release-notes]
Expand Down
11 changes: 1 addition & 10 deletions packages/opentelemetry-node/lib/instrumentations.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const {log} = require('./logging');
* "@opentelemetry/instrumentation-dataloader": import('@opentelemetry/instrumentation-dataloader').DataloaderInstrumentationConfig,
* "@opentelemetry/instrumentation-dns": import('@opentelemetry/instrumentation-dns').DnsInstrumentationConfig,
* "@opentelemetry/instrumentation-express": import('@opentelemetry/instrumentation-express').ExpressInstrumentationConfig,
* "@opentelemetry/instrumentation-fastify": import('@opentelemetry/instrumentation-fastify').FastifyInstrumentationConfig,
* "@opentelemetry/instrumentation-fs": import('@opentelemetry/instrumentation-fs').FsInstrumentationConfig,
* "@opentelemetry/instrumentation-generic-pool": import('@opentelemetry/instrumentation').InstrumentationConfig,
* "@opentelemetry/instrumentation-graphql": import('@opentelemetry/instrumentation-graphql').GraphQLInstrumentation,
Expand Down Expand Up @@ -80,9 +79,6 @@ const {
ExpressInstrumentation,
} = require('@opentelemetry/instrumentation-express');
const {FsInstrumentation} = require('@opentelemetry/instrumentation-fs');
const {
FastifyInstrumentation,
} = require('@opentelemetry/instrumentation-fastify');
const {
GenericPoolInstrumentation,
} = require('@opentelemetry/instrumentation-generic-pool');
Expand Down Expand Up @@ -177,8 +173,6 @@ const instrumentationsMap = {
'@opentelemetry/instrumentation-dns': (cfg) => new DnsInstrumentation(cfg),
'@opentelemetry/instrumentation-express': (cfg) =>
new ExpressInstrumentation(cfg),
'@opentelemetry/instrumentation-fastify': (cfg) =>
new FastifyInstrumentation(cfg),
'@opentelemetry/instrumentation-fs': (cfg) => new FsInstrumentation(cfg),
'@opentelemetry/instrumentation-generic-pool': (cfg) =>
new GenericPoolInstrumentation(cfg),
Expand Down Expand Up @@ -237,10 +231,7 @@ const instrumentationsMap = {
new WinstonInstrumentation(cfg),
};

const excludedInstrumentations = new Set([
'@opentelemetry/instrumentation-fastify',
'@opentelemetry/instrumentation-fs',
]);
const excludedInstrumentations = new Set(['@opentelemetry/instrumentation-fs']);

const otelInstrPrefix = '@opentelemetry/instrumentation-';
const otelInstrShortNames = new Set();
Expand Down
Loading
Loading