Skip to content

fix: replace createRef with useRef in Functional Components.#1524

Merged
nickofthyme merged 8 commits intoelastic:masterfrom
salvoravida:master
Dec 14, 2021
Merged

fix: replace createRef with useRef in Functional Components.#1524
nickofthyme merged 8 commits intoelastic:masterfrom
salvoravida:master

Conversation

@salvoravida
Copy link
Copy Markdown
Contributor

Summary

fix createRef with useRef in Functional Components.

@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Dec 10, 2021

💚 CLA has been signed

@nickofthyme
Copy link
Copy Markdown
Collaborator

Jenkins test this please

@salvoravida salvoravida changed the title fix createRef with useRef in Functional Components. fix(partition): createRef with useRef in Functional Components. Dec 10, 2021
@nickofthyme nickofthyme changed the title fix(partition): createRef with useRef in Functional Components. fix: replace createRef with useRef in Functional Components. Dec 14, 2021
@nickofthyme nickofthyme merged commit 9538417 into elastic:master Dec 14, 2021
nickofthyme pushed a commit that referenced this pull request Dec 17, 2021
# [41.0.0](v40.2.0...v41.0.0) (2021-12-17)

### Bug Fixes

* replace createRef with useRef in Functional Components. ([#1524](#1524)) ([9538417](9538417))

### Code Refactoring

* **goal:** remove deprecated config ([#1408](#1408)) ([312e31d](312e31d))

### Features

* **heatmap:** dark mode with theme controls ([#1406](#1406)) ([f29c8dd](f29c8dd))
* **legend:** custom legend width ([#1467](#1467)) ([51f50df](51f50df))

### BREAKING CHANGES

* **goal:** The `GoalSpec.config` prop is removed. All properties have been moved/renamed under new `Theme.goal` options with the following exceptions:

- `Config.margin` is now controlled by `Theme.chartMargins` and is no longer a margin ratio as before.
- `Config.backgroundColor` is now controlled by `Theme.background.color`, even though it's not yet used.
- `fontFamily` moved into each respective label styles
- `angleStart` and `angleEnd` are moved onto the `GoalSpec` as optional values.
- `sectorLineWidth`, `width` and `height` all removed as they were never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants